Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using :e (edit) tries to clobber the changes to the buffer, so vim stops it. This fixes this problem by using :buffer instead of :edit for open files. Note that the behavior with respect to dirty buffers is still somewhat half-assed: jumps to other buffers that are also dirty go to the wrong line. But this is no worse than it was, and to fix it all dirty nim buffers would need to be saved, and that means even greater divergence with what the command-line compiler is going to see, and that might end up being even more confusion-prone the present behavior anyway.