Closed
Conversation
The function would break if the passed parameters are a 1d array. parameter would then be a float. @roberCO found this bug in z-quantum-core. I thought I once made a PR about this, but apparently it was never merged.
Contributor
|
Can we add a test case where the user passes parameters with the wrong shape and ensures that an error is thrown? Just in case we refactor and this check gets deleted for some reason. |
Contributor
|
On second thought, this is not a bug this is a feature. You are supposed to provide an numpy array of parameters when you call this function. Is there a problem with this? If not, then I'm going to close this issue. |
Author
|
See this PR where it was seen as a bug:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The function would break if the passed
parametersare a 1d array.parameterwould then be a float.@roberCO found this bug in z-quantum-core. I thought I once made a PR about this, but apparently it was never merged.
Please verify that you have completed the following steps