Skip to content

Replace bytebuffer.array() call #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brokkoli71 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Replace bytebuffer.array() call #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcbf4c5
fix: `zstd` with sharding
LDeakin Feb 7, 2026
2b42228
replace ByteBuffer.array()
brokkoli71 Feb 9, 2026
752536f
Merge branch 'main' into replace-bytebuffer-array-call
brokkoli71 Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/dev/zarr/zarrjava/store/MemoryStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package dev.zarr.zarrjava.store;

import dev.zarr.zarrjava.utils.Utils;

import javax.annotation.Nonnull;
import javax.annotation.Nullable;
import java.io.InputStream;
Expand Down Expand Up @@ -55,7 +57,7 @@ public ByteBuffer get(String[] keys, long start, long end) {

@Override
public void set(String[] keys, ByteBuffer bytes) {
map.put(resolveKeys(keys), bytes.array());
map.put(resolveKeys(keys), Utils.toArray(bytes));
}

@Override
Expand Down
10 changes: 3 additions & 7 deletions src/main/java/dev/zarr/zarrjava/store/ZipStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package dev.zarr.zarrjava.store;

import dev.zarr.zarrjava.utils.Utils;

import javax.annotation.Nonnull;
import javax.annotation.Nullable;
import java.io.IOException;
Expand Down Expand Up @@ -62,13 +64,7 @@ public String getArchiveComment() throws IOException {
return null;
}

byte[] bufArray;
if (buffer.hasArray()) {
bufArray = buffer.array();
} else {
bufArray = new byte[buffer.remaining()];
buffer.duplicate().get(bufArray);
}
byte[] bufArray = Utils.toArray(buffer);

String comment = getZipCommentFromBuffer(bufArray);
if (comment != null) {
Expand Down
Loading