Open
Conversation
Author
|
Oh, I still want to make the term dynamic, but feel like I was taking too long as is, so I'll work on that so I know how to implement it for future use. Thanks! |
Contributor
|
Thanks @kel-gar - We'll take a look at this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Jen,
Here is my take-home ROI calculator exercise, thank you for your patience. I love what React can do and I had fun refactoring this application by building components that are reusable, easier to read and maintain with destructuring and by not duplicating code in the tables. Also, I put the seed data in its own file which is better practice than hard-coding data into a component.
Pros and Cons of the original application:
Pros- it's a quick app, it accomplishes the goal, it's all in one file
Cons- Too many lines of code, it's hard to read and maintain, code is duplicated, seed data is in the component instead of an external file
I look forward to hearing from you!
Thanks!
Kelly