Skip to content

prefer bin as directory name to hold binaries#47

Open
zancas wants to merge 6 commits intozcash:mainfrom
zingolabs:bin_include
Open

prefer bin as directory name to hold binaries#47
zancas wants to merge 6 commits intozcash:mainfrom
zingolabs:bin_include

Conversation

@zancas
Copy link
Contributor

@zancas zancas commented Mar 6, 2026

Local sanity check run after the name change:

getrawtransaction_sidechain.py:
Pass: True, Duration: 0 s

feature_nu6.py:
Pass: True, Duration: 1 s
......
indexer.py:
Pass: True, Duration: 3 s
..
fix_block_commitments.py:
Pass: True, Duration: 5 s
.........................
feature_backup_non_finalized_state.py:
Pass: True, Duration: 19 s
.......................................
addnode.py:
Pass: True, Duration: 39 s
TEST                                  | PASSED | DURATION

addnode.py                            | True   | 39 s
feature_backup_non_finalized_state.py | True   | 19 s
feature_nu6.py                        | True   | 1 s
fix_block_commitments.py              | True   | 5 s
getrawtransaction_sidechain.py        | True   | 0 s
indexer.py                            | True   | 3 s
ALL                                   | True   | 67 s (accumulated)
Runtime: 39 s

@zancas zancas changed the title include bin prefer bin as directory name to hold binaries Mar 6, 2026
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please grep the codebase for all remaining instances of "src" and inspect them individually to ensure you catch everything.

@zancas zancas marked this pull request as draft March 10, 2026 22:20
@zancas zancas marked this pull request as draft March 10, 2026 22:20
@zancas zancas marked this pull request as ready for review March 10, 2026 22:22
@zancas
Copy link
Contributor Author

zancas commented Mar 10, 2026

I have not confirmed that CI runs, which is necessary to validate the numerous changes inside .github.

@zancas zancas requested a review from nuttycom March 12, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants