Add translation history UI for Translation Tab#905
Closed
mircealungu wants to merge 4 commits intomasterfrom
Closed
Add translation history UI for Translation Tab#905mircealungu wants to merge 4 commits intomasterfrom
mircealungu wants to merge 4 commits intomasterfrom
Conversation
- Add getTranslationHistory() API method - Implement TranslateHistory component showing recent searches - Update Translate component to handle navigation from history - Clicking history items triggers search for that word Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
✅ Deploy Preview for voluble-nougat-015dd1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Extract res.data from apiGet response in getTranslationHistory - Add eslint-disable for intentional empty deps array in useEffect Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Extract search logic into performSearch(word) function - Call performSearch directly from history navigation useEffect - Remove formRef since form submission is no longer needed for auto-search Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use formatDistanceToNow from date-fns instead of custom formatTimeAgo - Reuse styles from Translate.sc.js (TranslationCard, NoResults, etc.) - Reduced from 173 to 93 lines Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
Author
|
Superseded by #907 (simplified approach without meaning_id) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getTranslationHistory()API methodTranslateHistorycomponent showing recent searches with timestampsTranslatecomponent to handle navigation from history (auto-search)Dependencies
Requires API PR: zeeguu/api#490
Test plan
/translate/history, verify list shows recent searches/translateand searches🤖 Generated with Claude Code