Use %p (pointer) format as basis for object ids #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more explicit, hopefully easier to understand. Can also be overridden as I intend to do next.
Pointers are more stable and will have the same value across invocations, unlike the counter method which may assign different ids to the same object on each run. Having stable IDs makes it easier to compare dumps from different times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only works in Lua 5.4 which adds
string.format("%p", object).Pointers are more stable and will have the same value across
invocations, unlike the counter method which may assign different ids to
the same object on each run.
Having stable IDs makes it easier to compare dumps from different times.