Skip to content

Fix output handlers #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Zash wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix output handlers #3

Zash wants to merge 2 commits into from

Conversation

@Zash
Copy link

@Zash Zash commented Jul 28, 2021

  • Gets rid of table allocation per output line.
  • Explicit arguments and concat.
  • Fixed CSV escaping

Zash added 2 commits July 28, 2021 21:02
@Zash
Reduce table allocations in TSV output format
002bd8b 
table.concat({...}, "\n") creates a table for each line, which becomes
immediate garbage. Handy when you don't know how many arguments will be
used, but here the number of arguments is known.  Suboptimal to allocate
more memory when this thing is usually run when a lot of memory is
already used.
@Zash
Rewrite CSV output formatter
935447d 
Previously simple values like '1' were escaped into '"""1"""' which
seems wrong.

Also gets rid of the table allocation for each line, see previous commit
for some words on that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Zash