Skip to content

feat: Add grid css declarations and tailwind mapper#62

Merged
msalihaltun merged 8 commits intomasterfrom
feat/add-figma-grid-css-declarations
Sep 25, 2025
Merged

feat: Add grid css declarations and tailwind mapper#62
msalihaltun merged 8 commits intomasterfrom
feat/add-figma-grid-css-declarations

Conversation

@msalihaltun
Copy link
Contributor

Change description

Description here

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2025

⚠️ No Changeset found

Latest commit: 39660a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@msalihaltun msalihaltun marked this pull request as draft September 23, 2025 12:24
@msalihaltun msalihaltun marked this pull request as ready for review September 25, 2025 08:31

declarations.push(Display.grid());

if (columnCount && columnSizes) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msalihaltun any scenario such as only columnCount exist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure. Let's ask @borulday.

I have only seen cases where both of these values are set at the same time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They both exist at the same time.

@msalihaltun msalihaltun merged commit 6d4fea8 into master Sep 25, 2025
2 checks passed
@msalihaltun msalihaltun deleted the feat/add-figma-grid-css-declarations branch September 25, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants