Skip to content

refactor(app-state): stop stdout logging in fetch error path#99

Merged
ori0o0p merged 1 commit intomainfrom
feature/appstate-no-stdout
Feb 16, 2026
Merged

refactor(app-state): stop stdout logging in fetch error path#99
ori0o0p merged 1 commit intomainfrom
feature/appstate-no-stdout

Conversation

@ori0o0p
Copy link
Member

@ori0o0p ori0o0p commented Feb 16, 2026

Summary

  • remove stdout printing from AppState.logError while preserving AppLogStore persistence
  • add regression coverage to ensure repository fetch failures no longer write to stdout
  • keep existing error handling behavior and user-facing messages unchanged

Closes #98

Test Plan

  • swift test --filter AppStateTests/testFetchRepositoriesErrorDoesNotPrintToStdout
  • swift test --filter AppStateTests/testFetchRepositoriesErrorStillAppendsToAppLogStore
  • swift test
  • swift build -c release

@ori0o0p ori0o0p merged commit f669ffc into main Feb 16, 2026
1 check passed
@ori0o0p ori0o0p deleted the feature/appstate-no-stdout branch February 16, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop AppState errors from printing to stdout

1 participant