Changes regarding loading and error handling #42
Open
powell-cord wants to merge 13 commits intozesage:masterfrom
Open
Changes regarding loading and error handling #42powell-cord wants to merge 13 commits intozesage:masterfrom
powell-cord wants to merge 13 commits intozesage:masterfrom
Conversation
… progress display
Updated Panorama to take progress builder to allow for custom progress indicators
…an issue loading the image passed as child
Added ability to pass error image which will be displayed in case of error loading image passed as child
…tly until progress is made
attempt to fix crash when closing app by setting scene to null in dispose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added fields to receive loading progress through a builder, error messages through an error builder and option to pass an image to be rendered in the panoramic view if original image encounters an error while loading.