API update to SkyBlockProfileMember

[Jforjo]

Added all the new API data shown in "skyblock_profile_v2.json" here: HypixelDatabase/HypixelTracking@74e6777
Resolves: #473

[Jforjo]

I put "feat(skyblock)" instead of "types(skyblock)" for most of them... whoops, sorry

[zikeji]

I put "feat(skyblock)" instead of "types(skyblock)" for most of them... whoops, sorry

You can actually do a rebase on that one. An interactive rebase from the starting commit, then tell it you want to update the commit messages. Finally, you can force push those changes to "overwrite" your branch. Force pushing is something that you don't do on the main branches, but is fine on feature branches (generally speaking, YMMV depending on the project and it's requirements).

[zikeji]

You can also update your description to do something like "Resolves #473" to get the automation aspect.

[Jforjo]

I put "feat(skyblock)" instead of "types(skyblock)" for most of them... whoops, sorry

You can actually do a rebase on that one. An interactive rebase from the starting commit, then tell it you want to update the commit messages. Finally, you can force push those changes to "overwrite" your branch. Force pushing is something that you don't do on the main branches, but is fine on feature branches (generally speaking, YMMV depending on the project and it's requirements).

All search results show a CLI solution... and I've never used the CLI for Git before, sorry

[zikeji]

Unfortunately the automate release tooling will bump the minor version if there are feat(ure) commits. In semver, a minor version should introduce a new feature, whereas I don't personally qualify adding more type definitions as a feature. That being said, I can just squash the merge, which I would probably do anyway. I'll want to review this in more depth when I'm more awake, it's 5AM and I've been on side quest after side quest - all because I wanted to update the Vitepress documentation 😓

[zikeji]

In conventional commits fix implies a bugfix. A formatting fix would fall under style. https://gist.github.com/pmutua/7008c22908f89eb8bd21b36e4f92b04f

But like I said - that doesn't exactly matter ultimately, since I'll squash the PR and it'll just get turned into one commit.

[Jforjo]

Unfortunately the automate release tooling will bump the minor version if there are feat(ure) commits. In semver, a minor version should introduce a new feature, whereas I don't personally qualify adding more type definitions as a feature. That being said, I can just squash the merge, which I would probably do anyway. I'll want to review this in more depth when I'm more awake, it's 5AM and I've been on side quest after side quest - all because I wanted to update the Vitepress documentation 😓

np lol
I'll have a look at the previous commits to see what to write next time. Literally first time every contributing to someone elses Github thing

[zikeji]

np lol I'll have a look at the previous commits to see what to write next time. Literally first time every contributing to someone elses Github thing

It's very much the same when working on a team at a company as well - whether you use GitHub, Gitlab, BitBucket, etc. the paradigms can mostly be mapped to eachother. A valuable skill for any SWE!