Skip to content

Integrate JSON-RPC method errors #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dorianvp wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

Integrate JSON-RPC method errors #644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4626b3c
chore(`errors`): initial integration
dorianvp Nov 6, 2025
74073f7
chore(`errors`): split into `blockchain_info`, `info` & `balance`
dorianvp Nov 6, 2025
95905c3
chore(`errors`): add nested error types
dorianvp Nov 9, 2025
dd8b129
Merge branch 'dev' into fix/error-integration
dorianvp Nov 9, 2025
34c9aeb
Merge branch 'dev' into fix/error-integration
dorianvp Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 20 additions & 1 deletion integration-tests/tests/json_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,8 +715,10 @@ async fn z_get_address_utxos_inner() {
mod zcashd {
use super::*;

#[allow(deprecated)]
pub(crate) mod zcash_indexer {
use zaino_state::LightWalletIndexer;
use zaino_fetch::jsonrpsee::response::block_header::GetBlockHeaderError;
use zaino_state::{FetchServiceError, LightWalletIndexer};
use zebra_rpc::methods::GetBlock;

use super::*;
Expand Down Expand Up @@ -939,6 +941,23 @@ mod zcashd {
.unwrap();
assert_eq!(zcashd_get_block_header, zainod_block_header_response);
}

// Try to fetch a non-existent block header
match zcashd_subscriber
.get_block_header(
"00000000008b4fdc4bae2868208f752526abfa441121cc0ac6526ddcb827befe".into(),
false,
)
.await
{
Err(FetchServiceError::RpcError(rpc_error)) => {
match GetBlockHeaderError::try_from(rpc_error) {
Ok(GetBlockHeaderError::MissingBlock { .. }) => (),
other => panic!("unexpected method error mapping: {:?}", other),
}
}
other => panic!("unexpected top-level error: {other:?}"),
}
}

#[tokio::test(flavor = "multi_thread")]
Expand Down
Loading
Loading