Open
Conversation
Stuck on not knowing what error is actually happening.
Closed
Contributor
|
it would be sensible for this to check against the "Use cases" section of the docs to make sure it's not duplicating the documentation. Also maybe the tutorial could be a section of that doc, or at least referenced for easier discovery. Or referenced on the readme itself. |
nachog00
reviewed
Mar 5, 2026
Contributor
There was a problem hiding this comment.
example_configs dir i like, I would probably place it under docs/
Member
|
This is great work. We need it to land next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
"Zainod launches as a Rust binary, with a single cargo invocation against the correct repo commit."