Open
Conversation
Owner
|
I'm not sure why I never saw a notification for this, but I'm interested. I'm going to take a look now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I found this tool on Nexus Mods and wanted to check it out, seems very cool. I'm very impressed at how nice it looks and works right out of the gate.
I'm a build/release engineer for a tech company and I've been playing with Github workflows lately, so I wanted to test out some stuff and this project was a great opportunity for me to try new things from a blank slate. When I was done, I figured I'd open a pull request in case you're interested in any/all of what I was experimenting with; I won't be offended if you're not interested in some/all of this though.
Changes:
ruff, an extremely fast linter, to find any code-related issues and fix them; the only thing it really complained about was having multiple statements on the same line, which isn't very pythonic, so I fixed that up a bit.blackto reformat the Python code also; it's very opinionated but it makes it easy to stay consistent.uv;uvkind of wraps up a lot of functionality, including replacingpip,pipx,venv, and a lot of other tools. In this case, simply doinguv syncwill download the correct version of Python for your platform (if you don't have it already), download all the dependencies, install them all into a new virtual environment, and boom. You can add more dependencies withuv add <packagename>pretty easily.main.specfile thatpyinstallercreated so that people don't need to type or remember the command-line arguments to build the application.ruffon every commit or PR tomain, and also runpyinstaller main.specto ensure that nothing has broken executable building.Like I said, if you don't care about any of this it's no problem, I did this for me more than anything so you can just close the PR and be done with it. That said, if you only want parts of this I can chop this down a lot and create separate PRs for everything.