fixup: string types to ID, where it is spotify.ID + ID to string#185
Open
jtagcat wants to merge 2 commits intozmb3:masterfrom
Open
fixup: string types to ID, where it is spotify.ID + ID to string#185jtagcat wants to merge 2 commits intozmb3:masterfrom
jtagcat wants to merge 2 commits intozmb3:masterfrom
Conversation
Newer profiles do look like spotify.ID, but a sizable 'legacy' chunk are just alphanumerical + few non-alphanumeric chars, most commonly dot.
Collaborator
|
Hmm, unfortunately, changing the values of these types would be a breaking change, which means that'd we'd have to go to /v3. I'll have a think if there's a few changes we could bundle as part of this. |
Collaborator
|
Reconsider this for the upcoming V3 milestone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.