changed grammar on main page #7
Conversation
From line 55, I modified the if statement. This will prevent displaying events on the list that occurred more than five days ago, improving the User Experience greatly. This change also corrects the "Jan 1" CalendarIcon bug. (For a later improvement, perhaps this page might distinguish between Past, Current, and Upcoming Events and label/group them appropriately.)
|
@anofibonacci is attempting to deploy a commit to the Zach's Projects Team on Vercel. A member of the Team first needs to authorize it. |
Cleaned up the wording and included "flock" as a synonym for "community" (gotta lean in to the brand!)
zmeyer44
left a comment
zmeyer44
left a comment
There was a problem hiding this comment.
I think this makes sense to be in 2 separate PRs since the changes are quite different. Happy to merge the grammatical changes!
There was a problem hiding this comment.
I think that this filtering should be done at a layer above this timeline component. I believe an example can be found in the Upcoming Events section of the Calendar details page. That way we keep this components as low level as possible and just serves to group events by day, thus, allowing us to group passed events together as well. The (daysAway < 1) line will still need to change. Also, If you could separate these into separate PR's that would be awesome.
There was a problem hiding this comment.
Yep, I agree that these should be two different PRs. Sorry, I'm not sure how to separate them, so I reverted the first change back to its original form.
anofibonacci
changed the title
2 participants
Cleaned up the wording and included "flock" as a synonym for "community" (gotta lean in to the brand!)