Skip to content

Conversation

@fiatjaf
Copy link

@fiatjaf fiatjaf commented Jan 10, 2024

It's better to just have the same information in a canonical place, saving everybody the hurdle of transmitting the repeated data over and over, and then checking all possible locations.

Since Flockstr is the only client doing these events for now as far as I know, whatever it does will be the actual standard, so if Flockstr checks for "description" data in 3 different places the standard becomes "description can be in any of these places" -- then in the future other apps will each put the description in one of these places, which forces all apps to check all places, but just to be sure apps will opt to publish the data in all of these places forever, which means events will be unnecessarily big forever.

The same applies to "address" and "location".

I am not sure my changes here are fully correct, but I can improve them if you agree with the changes.

Also I recommend following the same approach for other events that Flockstr is generating, the subscription stuff, for example. But I didn't change these since I don't know what is the preferred way. I suggest that you pick one standard and be strict about it. Thank you!

@vercel
Copy link

vercel bot commented Jan 10, 2024

@fiatjaf is attempting to deploy a commit to the Zach's Projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Owner

@zmeyer44 zmeyer44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Just had one small change to remove an extra reference to "description" tag

Co-authored-by: zmeyer44 <54515037+zmeyer44@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants