Potential deadlock fix #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loadTestsFromTestCase()
icemac
changed the base branch from
master
to
config-with-zope-product-template-46a5f4f9
Member
|
Hi @ianjosephwilson, thank you for this PR. In #92 I updated the environment to current Python versions etc. I redirected your branch to that PR and updated it with the changes there, so we can see in CI the result of the changes. |
Member
|
The tests ran successfully. 🙌 |
icemac
approved these changes
Nov 24, 2025
icemac
merged commit 234398d
into
zopefoundation:config-with-zope-product-template-46a5f4f9
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a potential fix for the deadlocking issue although I have had a hard time running the tests in an organized manner. I think the issue might stem from this issue:
my-program-is-hanging-when-i-say-table-drop-metadata-drop-all
I think the deadlock (one of the deadlocks?) starts at the
drop_all()in the tearDownReadMe function because the result of thefetchall()in the doctests is getting stuck in the doctest runner somehow.Let me know if you are able to run the tests on your side.