This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Open
Conversation
letfn isn't having its locals registered as part of the letfn* transformation, so its bindings weren't visible to the analyzer inside nested let expressions. So swallowing analysis errors as riddley 0.1.7 gets this use case working, but the right fix is probably to register locals for letfn. refs ztellman#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #3 - potentially the wrong one, but bumping riddley can't hurt, right?
The actual issue:
letfnisn't having its locals registered as part of theletfn*transformation, so its bindings aren't visible to the analyzer inside nestedletexpressions. So swallowing analysis errors as riddley 0.1.7 gets this use case working, but I'm assuming the right fix is to register locals forletfn.In digging into a potential locals-registering solution, my quicky & easy (but dirty, poking at internals) idea:
didn't work, got a
java.lang.UnsupportedOperationException: Can't type hint a primitive local.Surprisingly (to me), inlining the implementation of
let-bindingsseemed to do the trick:But that seemed pretty awful, and might not even be necessary - I don't have a full mental model of the consequences of analysis errors in this context.