Fix to correctly handle browsers's HTTP_ACCEPT_LANGUAGE correctly#3
Open
mvdberge wants to merge 3 commits intozuiderkwast:masterfrom
Open
Fix to correctly handle browsers's HTTP_ACCEPT_LANGUAGE correctly#3mvdberge wants to merge 3 commits intozuiderkwast:masterfrom
mvdberge wants to merge 3 commits intozuiderkwast:masterfrom
Conversation
contain a qvalue (e.g. 'en-US;q=0.5'). * Bump version to today's date.
Author
|
Added fixes for tab/space problems |
zuiderkwast
reviewed
Dec 19, 2016
| // 3. Set the UI language to one of the browser's accepted languages | ||
| $languages = split(',', preg_replace('/\(;q=\d+\.\d+\)/i', '', getenv('HTTP_ACCEPT_LANGUAGE'))); | ||
| foreach ($languages as $l) { | ||
| $l = substr($l, 0, strpos($l, ';')); |
Owner
There was a problem hiding this comment.
Why not just change the preg_replace a few lines above to remove any semicolon and everything following it, i.e. preg_replace('/;.*/', '', getenv('HTTP_ACCEPT_LANGUAGE'))?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to correctly handle browsers's HTTP_ACCEPT_LANGUAGE correctly which can contain a qvalue (e.g. 'en-US;q=0.5')
Bump version to today's date.