Update Node to v6.11.2 #4
Conversation
|
Tests are currently failing and I'm not exactly sure why. I'll have to look into it some more. |
|
@sbeca thanks for PR! |
demo/index.html
Outdated
| })(); | ||
|
|
||
| let fps = 60; | ||
| setInterval(function() { |
There was a problem hiding this comment.
setInteval is not good idea for animation loop in browsers
https://stackoverflow.com/questions/38709923/why-is-requestanimationframe-better-than-setinterval-or-settimeout
|
Hi @zuker, I have updated the code so that all tests pass now and have switched back to using requestAnimationFrame. I have also rebased to remove the commit noise so this PR is ready for review again. |
|
Hi @zuker, any update on this pull request? |
|
Apparently, this pull request on SWIG fixes this: swig/swig#968 |
3 participants
This PR updates Node to v6.11.2. It also updates all dependencies to the latest versions that are possible while maintaining support for Node v6.11.2.
I tried updating to Node v7.10.0 but it appears that SWIG doesn't yet support it as I got a bunch of compile errors so decided that v6.11.2 was a good compromise.