Conversation
- Change the onboarding wrapper logo - Put a background image for the wrapper - Changed the positioning of the logo
ickynavigator
left a comment
ickynavigator
left a comment
There was a problem hiding this comment.
why do we have alternate pages for signup and otp?
| <NumberInput | ||
| hideControls | ||
| classNames={{ input: classes.input }} | ||
| h={45} | ||
| w={50} | ||
| maxLength={1} | ||
| /> | ||
| <NumberInput | ||
| hideControls | ||
| classNames={{ input: classes.input }} | ||
| h={45} | ||
| w={50} | ||
| maxLength={1} | ||
| /> | ||
| <NumberInput | ||
| hideControls | ||
| classNames={{ input: classes.input }} | ||
| h={45} | ||
| w={50} | ||
| maxLength={1} | ||
| /> | ||
| <NumberInput | ||
| hideControls | ||
| classNames={{ input: classes.input }} | ||
| h={45} | ||
| w={50} | ||
| maxLength={1} | ||
| /> | ||
| <NumberInput | ||
| hideControls | ||
| classNames={{ input: classes.input }} | ||
| h={45} | ||
| maxLength={1} | ||
| w={50} | ||
| /> | ||
| <NumberInput | ||
| hideControls | ||
| classNames={{ input: classes.input }} | ||
| h={45} | ||
| maxLength={1} | ||
| w={50} | ||
| /> |
There was a problem hiding this comment.
This number input doesn't store the value anywhere.
Also Mantine provides a pin input that you can use instead of recreating that design
| <FormTitle | ||
| title="Verify your email address!" | ||
| subtitle="We have sent your code " | ||
| boldSubtitle={"Kamsiyo@gmail.com"} |
There was a problem hiding this comment.
this mail should not be hardcoded
| bg={theme.colors.secondary[5]} | ||
| className={classes.continueBtn} | ||
| > | ||
| Continue |
There was a problem hiding this comment.
the API is ready so this function should be connected properly
| top: "0", | ||
| height: "75px", | ||
| borderBottom: "1px solid #F9DBB6", | ||
| // height: "75px", |
There was a problem hiding this comment.
remove commented code
| { | ||
| path: "alternative-signup", | ||
| element: <LoginWrapper />, | ||
| errorElement: <ErrorPage />, | ||
| children: [ | ||
| { | ||
| index: true, | ||
| element: <AlternativeSignup /> | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| path: "alternative-signup-otp", | ||
| element: <LoginWrapper />, | ||
| errorElement: <ErrorPage />, | ||
| children: [ | ||
| { | ||
| index: true, | ||
| element: <AlternativeSignupOtp /> | ||
| } | ||
| ] |
There was a problem hiding this comment.
why do we have alternate pages?
| size="md" | ||
| autoComplete="false" | ||
| classNames={{ input: classes.inputField }} | ||
| {...LoginForm.getInputProps("email")} |
There was a problem hiding this comment.
you used the wrong get input props in the functions
update this
There was a problem hiding this comment.
why is there an alternate signup page
| <Button | ||
| fullWidth | ||
| mt="xl" | ||
| size="md" | ||
| variant="outline" | ||
| disabled={true} | ||
| className={classes.outlineBtn} | ||
| leftIcon={<IconBrandGoogle size={14} />} | ||
| > | ||
| Login with Google | ||
| </Button> |
There was a problem hiding this comment.
we don't need the login with google button for now
| Enter here | ||
| </Text> | ||
| <Flex gap={10} justify="space-between"> | ||
| <NumberInput |
There was a problem hiding this comment.
use the pin input instead
| <Button | ||
| fullWidth | ||
| mt="xl" | ||
| size="md" | ||
| variant="outline" | ||
| disabled={true} | ||
| className={classes.outlineBtn} | ||
| leftIcon={<IconBrandGoogle size={14} />} | ||
| > | ||
| Login with Google |
There was a problem hiding this comment.
remove google signup
2 participants
Fixes Issue/Linear Ticket
Changes proposed
Onboarding pages
Check List (Check all the applicable boxes)
🚨Please review the style guide for contributing and guidelines for contributing to this repository.
Screenshots/ Videos