Skip to content

heap: clone the variadic slice in Heap.From #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnojus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

heap: clone the variadic slice in Heap.From #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion heap/heap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
package heap

import (
"slices"

g "github.com/zyedidia/generic"
)

Expand All @@ -23,7 +25,7 @@ func New[T any](less g.LessFn[T]) *Heap[T] {

// From returns a new heap with the given less function and initial data.
func From[T any](less g.LessFn[T], t ...T) *Heap[T] {
return FromSlice(less, t)
return FromSlice(less, slices.Clone(t))
}

// FromSlice returns a new heap with the given less function and initial data.
Expand Down