Fix invalid, unnecessary XHTML vestiges in root element#60
Open
ches wants to merge 1 commit intozyro:masterfrom
Open
Fix invalid, unnecessary XHTML vestiges in root element#60ches wants to merge 1 commit intozyro:masterfrom
ches wants to merge 1 commit intozyro:masterfrom
Conversation
If `xml:lang` is kept, `lang` must also be used *and they must be
exactly the same*. This was failing validation out of the box.
The `xmlns` and `xml:lang` are no longer needed for HTML5:
http://diveintohtml5.info/semantics.html#html-element
Finally, Hugo has a `languageCode` config setting, let's use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
xml:langis kept,langmust also be used and they must be exactly the same. This was failing validation out of the box.The
xmlnsandxml:langare no longer needed for HTML5:Finally, Hugo has a
languageCodeconfig setting, let's use it.