Open
Conversation
Contributor
Author
|
Tested this after cleaning the branch, it seems to test well, it looks like I did clean up the branch properly and it is still showing 7 files changed. This could probably use further testing but I also think it's still technically an improvement over the pathfinding we have on live, and it does actually fix instances of not being able to attack NPCs - I haven't run into that issue once on this branch (torag, cows on certain tiles, etc). Still, further testing is likely a good idea. |
Contributor
Author
|
Note: I should probably comment out the print messages (but leave them in the codebase for helpful debugging) |
Contributor
Author
|
This is ready for review/testing now. |
Need less debugging but more testing so time to add back the NPC spawns
This reverts commit 4fa2e7e.
This reverts commit b75847f.
It didn't work.
This reverts commit 86577ad.
These are very helpful where they are placed, so I would strongly recommend we just leave them in the codebase with them commented out.
ipkpjersi
force-pushed
the
npc-size-pathing
branch
from
ceec9cb to
92558bd
Compare
Contributor
Author
|
Resolved conflicts with my refactoring PR, hopefully no more conflicts in the future with this one lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wow, this was a ton of effort to clean up this PR but I think I did it properly. I tried many things, but ultimately I had to interactive rebase and just drop the commits I didn't want that were from other branches. My old PR I closed was 7 files changed and this new PR is 7 files changed, so it's extremely likely I did clean up this branch properly.
Anyway, onto this feature:
This is probably fine to merge. It doesn't fix all pathing bugs that currently exist (it doesn't fix player clipping when moving/attacking/clicking on objects etc), that would likely be a ton of work, but this does address not handling NPC size > 1 pathing, and it doesn't seem to introduce any new bugs.
With that said, I'll go ahead and mark this as draft for now so we can make sure it gets tested more first since I don't really consider it completely fully tested.Marked as ready, we can review it/merge it whenever.