Conversation
t-bast
force-pushed
the
commit-sig-batch
branch
from
0242acd to
32dfa2d
Compare
We introduce a `CommitSigBatch` class to group `commit_sig` messages when splice transactions are pending. We use this class to ensure that all the `commit_sig` messages in the batch are sent together to our peer, without any other messages in-between. When we receive `commit_sig` messages that contain the `batch` TLV, we group them directly in the `PeerConnection` before relaying them as a batch to the channel.
t-bast
force-pushed
the
commit-sig-batch
branch
from
32dfa2d to
94d7ea1
Compare
pm47
reviewed
Oct 1, 2025
modules/core/src/commonMain/kotlin/fr/acinq/lightning/channel/Commitments.kt
Outdated
Show resolved
Hide resolved
modules/core/src/commonMain/kotlin/fr/acinq/lightning/io/Peer.kt
Outdated
Show resolved
Hide resolved
modules/core/src/commonMain/kotlin/fr/acinq/lightning/wire/LightningMessages.kt
Outdated
Show resolved
Hide resolved
pm47
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been some discussion on the splicing spec around batching the set of
commit_sigmessages that are sent while a splice is ongoing (see lightning/bolts@b5b5572).In this PR, we ensure that our
commit_sigmessages are sent as a batch (no other messages can be interleaved betweencommit_sigmessages). We also receivecommit_sigmessages as a batch, which means we must wait for ACINQ/eclair#3083 to be deployed before merging this PR.We don't yet implement the
start_batchmessage that was introduced in the BOLTs: this will be done onceeclairsupports it and the spec PR is merged (see #768).