Minor translation tweaks #2346
Merged
Minor translation tweaks #2346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Performance Test ResultsComparing 040e0ec vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
katinthehatsite
approved these changes
Jan 5, 2026
Contributor
katinthehatsite
left a comment
katinthehatsite
left a comment
There was a problem hiding this comment.
This looks good to me, I only reviewed the phrases that were changed in this PR and not all the comments from the Slack thread though 👍
nightnei
reviewed
Jan 5, 2026
| showLabels | ||
| valueLabel={ formattedSize } | ||
| limitLabel={ formattedLimit } | ||
| // translators: %s is a filesize string. This label is displayed if a sync archive is larger |
Contributor
There was a problem hiding this comment.
NIT I am thinking, does it make sense to add an example with such a "translators" comment?
e.g::
Suggested change
| // translators: %s is a filesize string. This label is displayed if a sync archive is larger | |
| // translators: %s is a filesize string, e.g. "1.3GB over". This label is displayed if a sync archive is larger |
Of course, it's obvious, but if we go this way with "translators", maybe we could have it as an agreement for the future cases. Current one is preety good w/o it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
p1767093925737899-slack-C06DRMD6VPZ
Proposed Changes
Minor translation tweaks to ensure consistency and good translations.
Testing Instructions
Code review should suffice
Pre-merge Checklist