Skip to content

Updates to EXT_feature_metadata#11

Merged
ptrgags merged 4 commits intoCesiumGS:3d-tiles-next-revfrom
donmccurdy:review-EXT_feature_metadata
Sep 7, 2021
Merged

Updates to EXT_feature_metadata#11
ptrgags merged 4 commits intoCesiumGS:3d-tiles-next-revfrom
donmccurdy:review-EXT_feature_metadata

Conversation

@donmccurdy
Copy link
Member

From #9

  • Refine binary data storage to avoid breaking changes to upstream glTF 2.0
  • Remove prefix: _FEATURE_ID_#FEATURE_ID_#
  • Define ID and NAME semantics directly in the document

Copy link

@ptrgags ptrgags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall these changes look good, I had a couple points for discussion

donmccurdy and others added 2 commits September 7, 2021 09:16
@lilleyse lilleyse changed the base branch from 3d-tiles-next to 3d-tiles-next-rev September 7, 2021 17:38
@donmccurdy donmccurdy marked this pull request as draft September 7, 2021 17:39
@donmccurdy
Copy link
Member Author

Converted this to a draft for the time being – @lilleyse if I understand correctly you'll start a branch off 3d-tiles-next and I'll rebase the PR onto that instead?

@donmccurdy donmccurdy marked this pull request as ready for review September 7, 2021 18:07
@donmccurdy
Copy link
Member Author

donmccurdy commented Sep 7, 2021

Thanks! PR points to 3d-tiles-next-rev now, I think this might be ready to merge and I'll start a new PR for the next batch of changes?

/cc @ptrgags

@donmccurdy donmccurdy requested a review from ptrgags September 7, 2021 18:09
@ptrgags
Copy link

ptrgags commented Sep 7, 2021

@donmccurdy looks good, I'm going to merge this. Thanks!

@ptrgags ptrgags merged commit d2f0f47 into CesiumGS:3d-tiles-next-rev Sep 7, 2021
@donmccurdy donmccurdy deleted the review-EXT_feature_metadata branch September 7, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments