Updates to EXT_feature_metadata#11
Merged
ptrgags merged 4 commits intoCesiumGS:3d-tiles-next-revfrom Sep 7, 2021
Merged
Conversation
ptrgags
reviewed
Sep 3, 2021
ptrgags
left a comment
There was a problem hiding this comment.
Overall these changes look good, I had a couple points for discussion
Co-authored-by: Peter Gagliardi <ptrgags@gmail.com>
Member
Author
|
Converted this to a draft for the time being – @lilleyse if I understand correctly you'll start a branch off |
Member
Author
|
Thanks! PR points to /cc @ptrgags |
|
@donmccurdy looks good, I'm going to merge this. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #9 –
_FEATURE_ID_#→FEATURE_ID_#