Rename EXT_feature_metadata → EXT_mesh_features#20
Merged
ptrgags merged 2 commits intoCesiumGS:3d-tiles-next-revfrom Sep 27, 2021
Merged
Rename EXT_feature_metadata → EXT_mesh_features#20ptrgags merged 2 commits intoCesiumGS:3d-tiles-next-revfrom
ptrgags merged 2 commits intoCesiumGS:3d-tiles-next-revfrom
Conversation
Member
Author
ptrgags
reviewed
Sep 27, 2021
ptrgags
left a comment
ptrgags
left a comment
There was a problem hiding this comment.
@donmccurdy looks good, though again, some files include the extension name in the filename, make sure to rename those too.
I'm also going to hold off on merging until we discuss https://github.com/CesiumGS/3d-tiles/pull/483/files#r714202819 later today.
extensions/2.0/Vendor/EXT_mesh_features/schema/gltf.EXT_feature_metadata.schema.json
Show resolved
Hide resolved
Member
Author
Resolved. 👍
Sounds good! |
|
Merging, thanks @donmccurdy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #19, following discussion in #17.
Will likely want some additional rephrasing, beyond the find/replace here, but will do that in a separate PR.