Rename EXT_feature_metadata → EXT_mesh_features#19
Closed
donmccurdy wants to merge 73 commits intoCesiumGS:3d-tiles-next-revfrom
Closed
Rename EXT_feature_metadata → EXT_mesh_features#19donmccurdy wants to merge 73 commits intoCesiumGS:3d-tiles-next-revfrom
donmccurdy wants to merge 73 commits intoCesiumGS:3d-tiles-next-revfrom
Conversation
…eTable.property.schema.json Co-authored-by: Peter Gagliardi <ptrgags@gmail.com>
…ta-v2.2 EXT_feature_metadata: Resolve 'type' / 'componentType' overlap, support VECN/MATN types
…ta-v2.1 EXT_feature_metadata: Simplify references to tables, textures, and IDs
…feature indicators.
…ta-v2.3 EXT_feature_metadata: Allow null feature IDs and noData property values
…s/propertyTextures
…ta-v2.4 EXT_feature_metadata: featureTables/featureTextures → propertyTables/propertyTextures
Member
Author
lilleyse
force-pushed
the
3d-tiles-next-rev
branch
from
36ceb70 to
ea7479e
Compare
ptrgags
reviewed
Sep 27, 2021
ptrgags
left a comment
ptrgags
left a comment
There was a problem hiding this comment.
@donmccurdy noticed a couple filenames that need to be updated.
Also as we talked about in Slack, you might need to rebase your branch to pick up recent changes, I notice the diff only does additions, not renames.
| @@ -0,0 +1,50 @@ | |||
| { | |||
There was a problem hiding this comment.
Make sure to update the filename of the JSON file, it still uses EXT_feature_metadata. There are a couple other files like this.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following discussion in #17.
Will likely want some additional rephrasing, beyond the find/replace here, but will do that in a separate PR.