feat: add ethauth option for dapp client connect (0xsequence#963) #321
feat: add ethauth option for dapp client connect (0xsequence#963) #321Dargon789 wants to merge 34 commits intoDargon789:vercel-dargon789-forgefrom
Conversation
Bumps [next](https://github.com/vercel/next.js) from 15.5.9 to 15.5.10. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v15.5.9...v15.5.10) --- updated-dependencies: - dependency-name: next dependency-version: 15.5.10 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: VojtechVitek <139342+VojtechVitek@users.noreply.github.com>
* Add env injection for core and wdk * wdk: use injected timer for auth key retry delay
* feat: add ethauth option for dapp client connect * Update tests
* [AUTOMATED] Update: proto/clients/indexer*.gen.ts * [AUTOMATED] Update: proto/clients/indexer*.gen.ts * [AUTOMATED] Update: proto/clients/indexer*.gen.ts * [AUTOMATED] Update: proto/clients/indexer*.gen.ts * [AUTOMATED] Update: proto/clients/indexer*.gen.ts * [AUTOMATED] Update: proto/clients/indexer*.gen.ts * [AUTOMATED] Update: proto/clients/indexer*.gen.ts * [AUTOMATED] Update: proto/clients/indexer*.gen.ts * [AUTOMATED] Update: proto/clients/indexer*.gen.ts --------- Co-authored-by: marino39 <722509+marino39@users.noreply.github.com> Co-authored-by: pkieltyka <18831+pkieltyka@users.noreply.github.com> Co-authored-by: xiam <385670+xiam@users.noreply.github.com>
* fix(relayer): wrap feeOptions calldata for simulation * fix(relayer): request FeeOptions as wallet (match wallet-webapp-v3) * fix(relayer): restore AbiFunction import
…967) * Use multicall3 to aggregate queued payload checking across N signers * Adding contracts object to Network type to store per network contract configs for common contracts like ensUniversalResolver and multicall3 * Parallelzing fetched queued payloads and adding fallback for when multicall3 batching either fails or is not configured on the network * Add includeTestnets option to RecoverySettings, default: false so fetchingQueuedPayloads can skip testnets to reduce requests
* Updating happy-dom, vitest, prettier, and syncpack dev dependencies * Updating turbo repo * Updating lefthook * Updating rimraf * Updating @types/node * Updating dotenv * Updating nodemon and esbuild for primitives-cli
…ages/indexer (#969) * Move indexer clients to packages/services/indexer and remove old packages/indexer * Disable noUncheckedIndexedAccess for indexer package
Co-authored-by: marino39 <722509+marino39@users.noreply.github.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @Dargon789, your pull request is larger than the review limit of 150000 diff characters
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces ETHAuth support for dapp client connections, allowing for secure and flexible authentication. It also includes significant refactoring to abstract environment dependencies, improving the wallet development kit's adaptability across different JavaScript environments. Key services like the relayer and recovery modules have received functional and performance enhancements, including batching capabilities and refined precondition checks. The development workflow is also improved with new pre-commit hooks for code quality and comprehensive dependency updates across the monorepo. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive update across numerous @0xsequence packages, primarily focusing on a 3.0.0-beta.19 release candidate. Key changes include version bumps for all affected packages, updates to next and @types/node dependencies, and the addition of lint and typecheck commands to pre-commit hooks. Many packages now include new eslint.config.js files and have been refactored to use ES module imports (.js extensions). Significant updates were made to the packages/services/indexer due to a webrpc-gen upgrade, resulting in numerous API and type definition changes, including new fields for token balances and transaction history, and the introduction of queryKey for React Query integration. The packages/services/relayer received updates to its feeOptions method signature, improved type safety for precondition checks, and optimized Recovery.fetchQueuedPayloads to use Multicall3 for batching. The packages/wallet/core package now includes environment resolution utilities (env.ts) and updates to passkey handling to support custom WebAuthn implementations. The packages/wallet/dapp-client introduces ETHAuth proof persistence and caching for signed calls. The packages/wallet/primitives package adds new chain IDs, refines network contract definitions to include multicall3 addresses, and improves JSON serialization for attestations and configurations. Finally, packages/wallet/wdk integrates the new environment utilities, updates passkey handling to use a provider pattern, and enhances cron job management. A review comment highlighted that the files property in packages/wallet/core/eslint.config.js was commented out, causing the @typescript-eslint/no-explicit-any rule to be disabled globally instead of just for test files, which was suggested to be corrected for better type safety.
|
@Mergifyio update |
☑️ Nothing to do, the required conditions are not metDetails
|
|
@taylanpince is attempting to deploy a commit to the Foundry development Team on Vercel. A member of the Team first needs to authorize it. |
8 participants
No description provided.