Add more trace prints to indicate when each Phase starts + re-word some info logs#93
Draft
Shadowrs wants to merge 2 commits intoFabricMC:mainfrom
Draft
Add more trace prints to indicate when each Phase starts + re-word some info logs#93Shadowrs wants to merge 2 commits intoFabricMC:mainfrom
Shadowrs wants to merge 2 commits intoFabricMC:mainfrom
Conversation
Shadowrs
commented
Aug 4, 2022
| printer.add().add("/**").add(" * Expected callback signature").add(" * /"); | ||
| printer.add("%s {", handlerSig); | ||
| printer.add(" // Method body").add("}").add().print(System.err); | ||
| printer.add(" // Method body").add("}").add().print(System.err).log(MixinEnvironment.logger); |
Author
There was a problem hiding this comment.
Send to the MixinEnv logger as well as sys.err
Author
|
The mixin profiler breakdown isn't printing to a log4j file yet and I'm not sure why |
|
Mixin in particular is a library where we don't want to diverge too much from upstream unless there's enough of a reason for it. Did you try a sampling based approach yet? It should be able to give a time usage breakdown as well, but without instrumenting the code and with deeper insight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested log4j.xml which splits mixin related logs to mixin.log instead of spamming latest.log and debug.log: