-
Notifications
You must be signed in to change notification settings - Fork 0
chore: format codebase with prettier #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
c742616 to
902c1f4
Compare
|
Droid finished @varin-nair-factory's task —— View job |
| "--output-format", | ||
| "stream-json", | ||
| "--skip-permissions-unsafe", | ||
| "--skip-permissions-unsafe", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P0] Fix string element missing indentation (syntax error)
This line is missing array indentation (it starts at column 1), which makes the test file invalid TS/JS and will cause parsing/CI failures.
| beforeAll(async () => { | ||
| const module = (await import( | ||
| `../src/run-droid?mcp-test=${Math.random().toString(36).slice(2)}`, | ||
| `../src/run-droid?mcp-test=${Math.random().toString(36).slice(2)}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P0] Fix invalid dynamic import syntax (missing trailing comma)
This multiline import( call is missing the trailing comma after the template string, which makes the file invalid syntax and will break the test suite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting changes look mostly fine, but the PR introduces a couple of syntax-breaking edits in base-action tests that will fail parsing/CI. Please fix the broken array indentation and the missing comma in the dynamic import, then rerun tests.
Summary
Apply consistent code formatting across the codebase using Prettier.
Changes
Testing