-
Notifications
You must be signed in to change notification settings - Fork 250
fix: Fix initial glitch (Context solution) #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👍 I still believe that we need to figure out how to do this using mount state, but in the meanwhile this is good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DnMllr Are you ok with this? I think it's more intuitive to fetch the size from the actual context then the DOMRenderer. Sorry, didn't mean to put this in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
�I think this is good.
|
Looks like I found a bug in this, trying to repro. |
|
@michaelobriena Rebased. Can you reproduce the bug? |
|
@alexanderGugel @pilwon 's example in #160 shows that it this solution breaks with first frame renderSize https://gist.github.com/pilwon/eea5126d50090eb48204 Edit: Talked with Alex offline and confirmed that this solution did indeed cause different issues with renderSize. |
|
@michaelobriena I'm confused. This PR wasn't meant to address #160 . This PR only fixes the initial glitch. @browles solution hasn't been merged in yet. IMO having the two PRs together should fix both issues, but I need to verify that. |
|
@michaelobriena Switched to naive |
|
I want to test this more, moving to the next minor. |
|
Sounds like this will be merged in very soon? |
|
@alexanderGugel this does not fix the issue. Run this branch with the seed project. |
|
@michaelobriena Are you sure you tested this properly? There is no way to test this using the seed project..... and everything works fine there. Please double check or be more specific. |
|
Yes I tested this. If you check out your branch and then run the seed code you will see the spinning logo in the top left for a frame. |
|
This conflicts with some other changes. Not sure why. I think I haven't rebased this properly. |
|
Closing. Will reopen tomorrow. |
Alternative to #185 using Context.
Change to the way we retrieve the Context Size:
getSizemethod has been moved fromDOMRenderertoContext.@michaelobriena