fix: sanitize extdisplay parameter to prevent XSS #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added htmlspecialchars() encoding to all instances of the extdisplay request parameter in form attributes across devices, users, and extensions views. The parameter was previously output directly into HTML attributes without sanitization, allowing potential XSS attacks via crafted URLs. This closes a reflected XSS vulnerability that could allow attackers to execute arbitrary JavaScript in admin sessions.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #176 — adds htmlspecialchars encoding to prevent xss in form attributes.
the extdisplay parameter was being output directly into the data-fpbx-delete attribute without sanitization across three views. an attacker could craft a url with embedded javascript that would execute in an admin's session.
changed all instances to use htmlspecialchars with ENT_QUOTES to properly escape any html/js payloads in the parameter.
tested that the forms still function correctly with normal input and that malicious payloads are now properly escaped in the rendered html.