Skip to content

fix: sanitize extdisplay parameter to prevent XSS #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmzoneill wants to merge 1 commit into
base: release/17.0
Choose a base branch
from
+3 −3
Open

fix: sanitize extdisplay parameter to prevent XSS #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion views/devices.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="display no-border">
<form class="popover-form fpbx-submit" name="frm_devices" action="config.php?display=devices<?php echo isset($_REQUEST['extdisplay']) && trim($_REQUEST['extdisplay']) != '' ? '&amp;extdisplay='.$_REQUEST['extdisplay'] : '' ?>" method="post" data-fpbx-delete="config.php?display=devices&amp;extdisplay=<?php echo $_REQUEST['extdisplay'] ?>&amp;action=del" role="form">
<form class="popover-form fpbx-submit" name="frm_devices" action="config.php?display=devices<?php echo isset($_REQUEST['extdisplay']) && trim($_REQUEST['extdisplay']) != '' ? '&amp;extdisplay='.htmlspecialchars($_REQUEST['extdisplay'], ENT_QUOTES, 'UTF-8') : '' ?>" method="post" data-fpbx-delete="config.php?display=devices&amp;extdisplay=<?php echo htmlspecialchars($_REQUEST['extdisplay'], ENT_QUOTES, 'UTF-8') ?>&amp;action=del" role="form">
<?php foreach ( $html['top'] as $elem ) {
echo $elem['html'];
} ?>
Expand Down
2 changes: 1 addition & 1 deletion views/extensions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="display no-border">
<form class="popover-form fpbx-submit" id="frm_extensions" onsubmit="return frm_extensions_onsubmit(this);" name="frm_extensions" action="config.php?display=extensions<?php echo isset($_REQUEST['extdisplay']) && freepbx_trim ($_REQUEST['extdisplay']) != '' ? '&amp;extdisplay='.$_REQUEST['extdisplay'] : '' ?>" method="post" data-fpbx-delete="config.php?display=extensions&amp;extdisplay=<?php echo $_REQUEST['extdisplay'] ?>&amp;action=del" role="form">
<form class="popover-form fpbx-submit" id="frm_extensions" onsubmit="return frm_extensions_onsubmit(this);" name="frm_extensions" action="config.php?display=extensions<?php echo isset($_REQUEST['extdisplay']) && freepbx_trim ($_REQUEST['extdisplay']) != '' ? '&amp;extdisplay='.htmlspecialchars($_REQUEST['extdisplay'], ENT_QUOTES, 'UTF-8') : '' ?>" method="post" data-fpbx-delete="config.php?display=extensions&amp;extdisplay=<?php echo htmlspecialchars($_REQUEST['extdisplay'], ENT_QUOTES, 'UTF-8') ?>&amp;action=del" role="form">
<?php foreach ( $html['top'] as $elem ) {
echo $elem['html'];
} ?>
Expand Down
2 changes: 1 addition & 1 deletion views/users.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="fpbx-container">
<form class="popover-form fpbx-submit" name="frm_users" action="config.php?display=users<?php echo isset($_REQUEST['extdisplay']) && trim($_REQUEST['extdisplay']) != '' ? '&amp;extdisplay='.$_REQUEST['extdisplay'] : '' ?>" method="post" data-fpbx-delete="config.php?display=users&amp;extdisplay=<?php echo $_REQUEST['extdisplay'] ?>&amp;action=del" role="form">
<form class="popover-form fpbx-submit" name="frm_users" action="config.php?display=users<?php echo isset($_REQUEST['extdisplay']) && trim($_REQUEST['extdisplay']) != '' ? '&amp;extdisplay='.htmlspecialchars($_REQUEST['extdisplay'], ENT_QUOTES, 'UTF-8') : '' ?>" method="post" data-fpbx-delete="config.php?display=users&amp;extdisplay=<?php echo htmlspecialchars($_REQUEST['extdisplay'], ENT_QUOTES, 'UTF-8') ?>&amp;action=del" role="form">
<?php foreach ( $html['top'] as $elem ) {
echo $elem['html'];
} ?>
Expand Down