-
Notifications
You must be signed in to change notification settings - Fork 1
(Changed) Update PHP version constraints, enhance Dependabot config, and remove Qodana workflow #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Delete the Qodana GitHub Actions workflow due to an expired key. - Simplify the CI configuration by removing obsolete code quality steps. - Ensure alternative tools are in place for code quality checks.
- Specify "composer" as the package ecosystem. - Define the Packagist registry to streamline dependency checks. - Set a weekly schedule for regular, controlled updates.
- Relax PHP version requirements to support PHP 8.2, 8.3, and 8.4. - Enhances compatibility for users across stable PHP releases. - Update documentation to reflect the revised version range.
📝 WalkthroughWalkthroughThe changes introduce a new Dependabot configuration for weekly updates of Composer packages via the Packagist registry. Additionally, a GitHub Actions workflow for Qodana code quality checks has been removed. Minor adjustments were also applied to the Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub as GitHub Actions
participant Dependabot as Dependabot Service
participant Packagist as Packagist Registry
GitHub->>Dependabot: Trigger weekly update for Composer packages
Dependabot->>Packagist: Request latest package update information
Packagist-->>Dependabot: Return package update data
Dependabot->>GitHub: Create/Update PR with dependency updates
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
Changelog updates: 🔄 2025-02-11 *Changed
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|
Auto-approved PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=========================================
Coverage 98.80% 98.80%
Complexity 26 26
=========================================
Files 1 1
Lines 84 84
=========================================
Hits 83 83
Misses 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
.github/workflows/dependabot.yml (1)
1-13:⚠️ Potential issueMove Dependabot configuration to the correct location.
The Dependabot configuration file should be located at
.github/dependabot.yml, not in the workflows directory. The current location.github/workflows/dependabot.ymlis incorrect and will not be recognized by Dependabot.Move the file using this command:
mv .github/workflows/dependabot.yml .github/dependabot.ymlThe configuration itself looks good and aligns with the PR objectives:
- Weekly updates for Composer packages
- Uses the official Packagist registry
- Targets the root directory where
composer.jsonis located🧰 Tools
🪛 actionlint (1.7.4)
1-1: unexpected key "version" for "workflow" section. expected one of "concurrency", "defaults", "env", "jobs", "name", "on", "permissions", "run-name"
(syntax-check)
1-1: "on" section is missing in workflow
(syntax-check)
1-1: "jobs" section is missing in workflow
(syntax-check)
2-2: unexpected key "registries" for "workflow" section. expected one of "concurrency", "defaults", "env", "jobs", "name", "on", "permissions", "run-name"
(syntax-check)
6-6: unexpected key "updates" for "workflow" section. expected one of "concurrency", "defaults", "env", "jobs", "name", "on", "permissions", "run-name"
(syntax-check)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/dependabot.yml(1 hunks).github/workflows/qodana_code_quality.yml(0 hunks)composer.json(2 hunks)
💤 Files with no reviewable changes (1)
- .github/workflows/qodana_code_quality.yml
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/dependabot.yml
1-1: unexpected key "version" for "workflow" section. expected one of "concurrency", "defaults", "env", "jobs", "name", "on", "permissions", "run-name"
(syntax-check)
1-1: "on" section is missing in workflow
(syntax-check)
1-1: "jobs" section is missing in workflow
(syntax-check)
2-2: unexpected key "registries" for "workflow" section. expected one of "concurrency", "defaults", "env", "jobs", "name", "on", "permissions", "run-name"
(syntax-check)
6-6: unexpected key "updates" for "workflow" section. expected one of "concurrency", "defaults", "env", "jobs", "name", "on", "permissions", "run-name"
(syntax-check)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: build (8.4)
- GitHub Check: guardrails/scan
- GitHub Check: build (8.3)
- GitHub Check: build (8.2)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (1)
composer.json (1)
10-10: LGTM!The formatting change in the keywords array looks good.
User description
Summary
This pull request refines our dependency management and CI configuration by updating the PHP version constraints in composer.json, enhancing the Dependabot configuration for Composer, and removing the obsolete Qodana workflow. These changes streamline our build process and ensure better compatibility across supported PHP versions.
Context and Background
Our PHP library initially supported only PHP ^8.2, which limited compatibility with later stable releases (PHP 8.3 and 8.4). Meanwhile, our CI pipeline included a Qodana workflow that has become redundant due to an expired key and alternative code quality tools being in place. These adjustments are part of our ongoing efforts to align with modern dependency management practices and simplify our CI configuration.
Problem Description
PHP Version Constraints:
The existing composer.json restricted support to PHP ^8.2, potentially excluding users on PHP 8.3 and 8.4.
Obsolete CI Workflow:
The Qodana GitHub Actions workflow, no longer functional due to an expired key, cluttered our CI configuration and added unnecessary complexity.
Solution Description
The changes address these issues by:
List of Changes
PR Type
Enhancement, Configuration changes
Description
Updated PHP version constraints to support PHP 8.2, 8.3, and 8.4.
Enhanced Dependabot configuration for Composer with weekly updates.
Removed obsolete Qodana workflow from CI configuration.
Changes walkthrough 📝
dependabot.yml
Added Dependabot configuration for Composer dependencies.github/workflows/dependabot.yml
qodana_code_quality.yml
Removed Qodana workflow from CI configuration.github/workflows/qodana_code_quality.yml
composer.json
Updated PHP version constraints in composer.jsoncomposer.json
requiresection to reflect updated constraints.Summary by CodeRabbit