(Changed) Performance optimisations, bug fixes, and Docker-based development setup #45

MarjovanLier · 2025-05-23T09:22:18Z

Summary

This merge request introduces significant performance optimisations to the StringManipulation library, addresses critical validation bugs, and establishes a Docker-first development workflow with automated testing and commit validation. Key improvements include optimised string replacement and search methods, enhanced date validation, and a consistent testing environment using Docker.

Context and Background

The StringManipulation library is a core component for various text processing tasks. To ensure its reliability, efficiency, and maintainability, these changes were necessary. The introduction of a Dockerized testing environment and pre-commit hooks aims to improve code quality, standardize the development process, and make onboarding easier for contributors. Performance enhancements directly impact applications relying on this library for string operations.

(Changed) Make StringManipulation final and update static to self references Make `StringManipulation` class final and replace `static` with `self`. Converted the `StringManipulation` class to `final` to prevent inheritance and replaced all occurrences of `static` with `self` for improved clarity and static binding. Additionally, updated development dependencies in `composer.json` to their latest versions for enhanced tooling support.

coderabbitai · 2025-05-23T09:22:25Z

📝 Walkthrough

Walkthrough

This update introduces extensive improvements to the StringManipulation project, including new Docker and pre-commit infrastructure, enhanced documentation, stricter code style and commit message enforcement, and significant performance optimizations. It adds new scripts, configuration files, and benchmarks, refactors core string manipulation logic for efficiency, and updates tests to cover edge cases and optimizations.

Changes

File(s)	Change Summary
.dockerignore, Dockerfile, docker-compose.yml, run-tests-docker.sh, test-runner.sh	Added Docker and Docker Compose configuration for PHP 8.3 test environments, with scripts for running tests inside containers and optimizing build contexts by ignoring unnecessary files.
.githooks/commit-msg, .gitmessage, commitlint-docker.sh, commitlint.config.js, package.json	Introduced conventional commit message enforcement via commitlint (with Docker wrapper), a sample message template, and npm scripts for hook setup. The commit-msg hook now validates messages and adds Signed-off-by lines automatically.
.pre-commit-config.yaml, setup-hooks.sh	Added pre-commit configuration and setup script to automate code style, linting, static analysis, and security checks using Dockerized hooks and standard pre-commit plugins.
CONTRIBUTING.md, CLAUDE.md, IMPROVEMENTS.md	Added comprehensive contributor guidelines, coding standards, and a summary of recent optimizations, bug fixes, and code quality improvements.
README.md	Updated to use British English spellings, removed the "Time Part Validation" feature, updated date validation examples, and adjusted example variable names for consistency.
src/StringManipulation.php	Refactored to a `final` class, optimized `strReplace` (using `strtr` for single-character replacements and early returns), added static caching for accent mappings, improved `searchWords` and `nameFix` for efficiency and clarity, updated `isValidDate` and `isValidTimePart` for full date and time validation, and made internal method call consistency improvements.
src/AccentNormalization.php	Removed duplicate character mappings in the accent removal arrays.
src/UnicodeMappings.php	Clarified and corrected PHPDoc comments for Unicode-to-UTF-8 mapping constants and usage examples.
composer.json	Updated development dependencies to newer versions and removed an obsolete flag from the `test:phan` script.
.phan/config.php	Set minimum PHP version to 8.3, reduced parallel processes, and expanded analysis to include the `tests` directory.
rector.php	Skipped the `RemoveConcatAutocastRector` rule to avoid conflicts with Psalm strict mode.
.gitignore	Added ignores for Qodana, Docker, pre-commit, Node.js, and temporary files.
qodana.yaml	Removed Qodana configuration file.
LICENSE, infection.json5, phpmd.xml, phpstan.neon, pint.json, qodana.sarif.json, updates.sh	Added missing trailing newlines to ensure POSIX compliance.
tests/Unit/StrReplaceTest.php, tests/Unit/Utf8AnsiTest.php	Added PHPDoc type annotations and new tests to safeguard and explicitly verify `strReplace` optimizations, including single-character and empty string handling.
tests/Unit/NameFixTest.php	Separated the `null` input test case from other negative tests for `nameFix`, using a dedicated assertion for `null`.
tests/Unit/IsValidTimePartTest.php	Expanded test data to include full date components and added cases for invalid dates and months. Updated docblocks accordingly.
tests/Benchmark/StringManipulationBenchmark.php	Introduced a new benchmark suite for all public methods, measuring and reporting performance before and after optimizations.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Git
    participant Pre-commit Hooks
    participant Docker
    participant Composer
    participant Test Suite

    Developer->>Git: git commit
    Git->>Pre-commit Hooks: Run pre-commit checks
    Pre-commit Hooks->>Docker: Run code style, lint, static analysis in containers
    Pre-commit Hooks->>Composer: Validate composer.json/lock
    Pre-commit Hooks->>Test Suite: Run PHPUnit and other tests
    Pre-commit Hooks->>Git: If all pass, allow commit
    Pre-commit Hooks->>Git: If fail, block commit
    Developer->>Git: git push
    Git->>Pre-commit Hooks: Run pre-push hooks (e.g., mutation tests)

Suggested reviewers

qodo-merge-pro

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

gemini-code-assist

Hello @MarjovanLier, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! Gemini here, providing a summary of this pull request to help everyone quickly understand the changes and context.

This pull request, authored by @MarjovanLier, focuses on improving the documentation and code quality of the project. The main goals are to standardize spelling to South African English, fix errors and inconsistencies in the README.md file, and address several code quality issues such as duplicate code, naming inconsistencies, and documentation inaccuracies within the source files.

Highlights

Documentation Spelling Standardization: Standardized spelling across the README.md file from American English to South African English (e.g., 'optimize' to 'optimise', 'standardize' to 'standardise').
README.md Corrections: Fixed several issues in README.md, including removing a duplicate section on UTF-8 to ANSI conversion, correcting a method reference from validateDate() to isValidDate(), removing references to a non-existent validateTime() method, and correcting output descriptions for utf8Ansi examples.
Code Quality Improvements: Addressed code quality issues by removing duplicate PHPDoc for removeAccents(), fixing a duplicate character ('ë') in the REMOVE_ACCENTS_FROM array, standardizing a parameter name ($valor to $value) in utf8Ansi(), and updating documentation for the UnicodeMappings trait.
Performance Optimization & Testing: Introduced a static cache for accent replacement mappings in removeAccents() for performance optimization and added new tests for the strReplace() method to specifically target single-character and empty string optimization paths and mutation testing.
Dependency Updates: Updated several development dependencies in composer.json to newer versions.

Changelog

Click here to see the changelog

README.md
- Standardized spelling (optimize -> optimise, standardize -> standardise, capitalizing -> capitalising, normalize -> normalise).
- Removed duplicate 'UTF-8 to ANSI Conversion' section.
- Corrected method reference from validateDate() to isValidDate() in the Date Validation example.
- Removed the 'Time Part Validation' section and its example, as the method does not exist.
- Corrected the output description for the utf8Ansi example from 'in ANSI format' to a simpler description.
composer.json
- Updated development dependencies: infection/infection (>=0.29.11 -> >=0.29.14), laravel/pint (>=1.20.0 -> >=1.21.1), phpstan/phpstan (>=2.1.4 -> >=2.1.8), rector/rector (>=2.0.9 -> >=2.0.10), vimeo/psalm (>=6.5.1 -> >=6.7).
src/AccentNormalization.php
- Removed a duplicate 'ë' character from the REMOVE_ACCENTS_FROM and REMOVE_ACCENTS_TO arrays.
src/StringManipulation.php
- Made the StringManipulation class final.
- Added a static property $ACCENTS_REPLACEMENT to cache accent replacement arrays for performance.
- Modified removeAccents() to use the new static cache for replacements.
- Changed static:: calls to self:: for consistency.
- Renamed the $valor parameter to $value in the utf8Ansi() method for clarity.
- Updated PHPDoc for removeAccents() and strReplace().
- Removed @psalm-suppress tags from utf8Ansi() and strReplace().
src/UnicodeMappings.php
- Updated documentation to clarify that the UTF8_ANSI2 constant maps Unicode escape sequences to UTF-8 characters, not Unicode characters to ANSI.
tests/Unit/StrReplaceTest.php
- Added testSingleCharacterOptimization() to verify the strtr optimization path.
- Added testSingleCharacterVsMultipleCharacter() to test the distinction between single and multiple character replacements and potential mutation testing scenarios.
- Added testEmptyStringOptimization() to test edge cases with empty subject or search/replace strings.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Docs get a polish,
Code gets a fix,
South African words,
A spelling mix.
Tests now run slick.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

qodo-code-review · 2025-05-23T09:22:49Z

Changelog updates: 🔄

2025-05-23

Changed

Standardised spelling to South African English throughout the codebase *
Improved documentation accuracy in README.md, removing references to non-existent methods
Fixed code quality issues including duplicate code and parameter naming inconsistencies

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

codecov · 2025-05-23T09:22:56Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d24e598) to head (fa25532).
Report is 1 commits behind head on main.

Additional details and impacted files

@@              Coverage Diff              @@
##               main       #45      +/-   ##
=============================================
+ Coverage     98.80%   100.00%   +1.19%     
- Complexity       26        33       +7     
=============================================
  Files             1         1              
  Lines            84        81       -3     
=============================================
- Hits             83        81       -2     
+ Misses            1         0       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

qodo-code-review · 2025-05-23T09:23:09Z

PR Code Suggestions ✨

Latest suggestions up to 91c3cce

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Optimize array initialization The current implementation creates new arrays on each call if the cache is empty. This is inefficient as it allocates memory unnecessarily. Consider using a direct assignment to the 'search' and 'replace' keys instead of recreating the entire array structure. src/StringManipulation.php [229-235] // Use a strict comparison instead of empty() if (count(self::$ACCENTS_REPLACEMENT['search']) === 0) { - self::$ACCENTS_REPLACEMENT = [ - 'search' => [...self::REMOVE_ACCENTS_FROM, ' '], - 'replace' => [...self::REMOVE_ACCENTS_TO, ' '], - ]; + self::$ACCENTS_REPLACEMENT['search'] = [...self::REMOVE_ACCENTS_FROM, ' ']; + self::$ACCENTS_REPLACEMENT['replace'] = [...self::REMOVE_ACCENTS_TO, ' ']; } Apply / Chat Suggestion importance[1-10]: 7 __ Why: This suggestion improves efficiency by updating only the relevant keys in the static property instead of reassigning the entire array, which can be a minor optimization for memory and performance. The change is accurate and contextually relevant.	Medium
General	Validate parameter types The optimization for single character replacements is a good performance improvement, but it doesn't handle the case where $search is a single character but $replace is an array. This could lead to unexpected behavior. Add a check to ensure $replace is also a string. src/StringManipulation.php [279-282] +// Optimize single character replacements using strtr which is faster for this case +if (is_string($search) && is_string($replace) && strlen($search) === 1) { + return strtr($subject, [$search => $replace]); +} - Apply / Chat Suggestion importance[1-10]: 6 __ Why: The suggestion correctly highlights the need to ensure both `$search` and `$replace` are strings before using `strtr`, which is already enforced in the code. While the check is present, the suggestion reinforces type safety, offering a minor improvement.	Low
Update

Previous suggestions

Suggestions up to commit 97fe4c0

Category	Suggestion	Impact
General	Use consistent naming convention The static property name uses uppercase with underscores, which doesn't follow PSR-12 naming conventions for properties. Consider renaming it to use camelCase format for better consistency with PHP standards. src/StringManipulation.php [42-45] -private static array $ACCENTS_REPLACEMENT = [ +private static array $accentsReplacement = [ 'search' => [], 'replace' => [], ]; Suggestion importance[1-10]: 5 __ Why: Renaming the static property to camelCase improves consistency with PSR-12 and PHP community standards, but this is a minor style improvement with limited impact on functionality.	Low
General	Improve comment accuracy The comment about using strict comparison instead of empty() is misleading since the code is already using a strict comparison. Additionally, if the property name is changed to camelCase as suggested, this code would need to be updated to match. src/StringManipulation.php [229-235] -// Use a strict comparison instead of empty() -if (count(self::$ACCENTS_REPLACEMENT['search']) === 0) { - self::$ACCENTS_REPLACEMENT = [ +// Initialize replacement arrays if not already populated +if (count(self::$accentsReplacement['search']) === 0) { + self::$accentsReplacement = [ 'search' => [...self::REMOVE_ACCENTS_FROM, ' '], 'replace' => [...self::REMOVE_ACCENTS_TO, ' '], ]; } Suggestion importance[1-10]: 4 __ Why: Updating the comment for accuracy and aligning the property name with the previous naming suggestion improves code clarity and maintainability, but the impact is minor and mostly stylistic.	Low

Suggestions up to commit 5768c3f

Category	Suggestion	Impact
Possible issue	Fix inconsistent return flow The current implementation has inconsistent return behavior. When $macFix is true, it returns immediately, but when $mcFix is true, it continues execution. This creates a potential bug where both conditions could be true but only the Mac replacement would be applied. Restructure to ensure consistent behavior. src/StringManipulation.php [169-178] // Fix mc/mac spacing if needed if ($mcFix) { $lastName = self::strReplace('Mc ', 'Mc', $lastName); } if ($macFix) { - return self::strReplace('Mac ', 'Mac', $lastName); + $lastName = self::strReplace('Mac ', 'Mac', $lastName); } return $lastName; Suggestion importance[1-10]: 7 __ Why: The suggestion addresses a subtle control flow issue where only one of the 'mc' or 'mac' fixes would be applied if both were true. By restructuring to always apply both replacements before returning, it improves correctness and consistency, though the practical impact may be limited.	Medium
General	Optimize array initialization The current implementation creates new arrays on each call when the cache is empty. This is inefficient as it allocates memory unnecessarily. Use direct assignment to the 'search' and 'replace' keys instead of recreating the entire array structure. src/StringManipulation.php [229-235] // Use a strict comparison instead of empty() if (count(self::$ACCENTS_REPLACEMENT['search']) === 0) { - self::$ACCENTS_REPLACEMENT = [ - 'search' => [...self::REMOVE_ACCENTS_FROM, ' '], - 'replace' => [...self::REMOVE_ACCENTS_TO, ' '], - ]; + self::$ACCENTS_REPLACEMENT['search'] = [...self::REMOVE_ACCENTS_FROM, ' ']; + self::$ACCENTS_REPLACEMENT['replace'] = [...self::REMOVE_ACCENTS_TO, ' ']; } Suggestion importance[1-10]: 6 __ Why: This suggestion proposes a minor optimization by assigning to the 'search' and 'replace' keys directly instead of recreating the entire array. While this is a small efficiency improvement, it does not significantly affect correctness or functionality.	Low

qodo-code-review · 2025-05-23T09:23:11Z

Manual-approval option for PR-Agent is disabled. You can enable it via a configuration file

gemini-code-assist

Code Review

This is a solid pull request that significantly improves documentation accuracy, consistency, and code quality. The standardisation to South African English throughout the documentation is well-executed, and the code refactorings enhance maintainability and performance.

Key improvements I noted:

Documentation Clarity: The updates to README.md (removing obsolete sections, correcting method references, improving example accuracy) and especially the UnicodeMappings.php trait documentation are excellent. The clarification regarding Unicode escape sequence decoding is particularly valuable.
Code Quality & Refinements: Making the StringManipulation class final and consistently using self:: for static calls are good practices for this type of utility class. The parameter renaming (e.g., $valor to $value in utf8Ansi) enhances readability and consistency.
Performance Optimisation: The introduction of caching for accent replacement mappings in the removeAccents method is a smart optimisation, likely to improve performance for scenarios involving frequent calls to this method.
Bug Fix: The removal of the duplicate 'ë' character in AccentNormalization.php is a good catch and corrects a potential data issue.
Testing: The new unit tests added in StrReplaceTest.php for string replacement optimisations (targeting PHP's internal strtr usage for single characters) and edge cases are a great addition. They increase confidence in the string replacement functionality under various conditions.

The changes are well-organized, and the intent behind each modification is clear from the PR description and the code itself. Great work on these enhancements!

Summary of Findings

PHPDoc Clarity for StringManipulation::strReplace: The PHPDoc for the StringManipulation::strReplace method (src/StringManipulation.php, line 267) describes it as an "optimised version" of PHP's str_replace. While it leverages PHP's native function (which has its own internal optimisations that the new tests help explore), the wrapper itself is a direct passthrough and doesn't add further optimisations beyond what str_replace() natively provides. Clarifying this in the PHPDoc (e.g., stating it's a consistent internal wrapper that utilizes PHP's str_replace) could prevent potential misunderstanding about where the optimisation lies. This was considered low severity and not commented on directly due to review settings.

Merge Readiness

This pull request is in excellent shape. The comprehensive documentation improvements, code quality enhancements, bug fixes, and new tests significantly benefit the project. I have not identified any critical, high, or medium severity issues that would block merging. While I am an AI and cannot formally approve PRs, based on my review, the changes appear ready for consideration by other reviewers for merging.

coderabbitai

Actionable comments posted: 4

🧹 Nitpick comments (4)

src/StringManipulation.php (4)
37-46: Good performance optimisation with caching.

Adding a static cache for accent replacement mappings improves performance by avoiding recreating arrays on every call to removeAccents(). The PHPDoc clearly explains the purpose and implementation.

Consider aligning array keys for better readability according to PER Coding Style 2.0:
    private static array $ACCENTS_REPLACEMENT = [
-        'search' => [],
-        'replace' => [],
+        'search'  => [],
+        'replace' => [],
    ];
🧰 Tools

🪛 GitHub Check: Codacy Static Code Analysis

[notice] 44-44: src/StringManipulation.php#L44
Array key not aligned correctly; expected 49 spaces but found 8

[notice] 45-45: src/StringManipulation.php#L45
Array key not aligned correctly; expected 49 spaces but found 8

[notice] 46-46: src/StringManipulation.php#L46
Closing parenthesis not aligned correctly; expected 48 spaces but found 4

82-87: Early return pattern improves code flow.

The switch from static:: to self:: provides consistency, and the early return pattern simplifies logic by avoiding unnecessary processing.

Add a period to the inline comment to match coding standards:
-// Early return if nameFix returned null
+// Early return if nameFix returned null.
🧰 Tools

🪛 GitHub Check: Codacy Static Code Analysis

[notice] 84-84: src/StringManipulation.php#L84
Inline comments must end in full-stops, exclamation marks, or question marks

🪛 GitHub Check: codecov/patch

[warning] 86-86: src/StringManipulation.php#L86
Added line #L86 was not covered by tests

100-104: Improved code structure with variable assignment before operation.

This refactoring improves readability by separating space normalization and trimming operations, while also handling potential null values from preg_replace().

Fix comment punctuation and add parentheses around the null coalescing operation:
-// Reduce spaces to a single space
+// Reduce spaces to a single space.

-// Return the trimmed result, ensuring we always have a string
-return trim($result ?? '');
+// Return the trimmed result, ensuring we always have a string.
+return trim(($result ?? ''));
🧰 Tools

🪛 GitHub Check: Codacy Static Code Analysis

[notice] 100-100: src/StringManipulation.php#L100
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 103-103: src/StringManipulation.php#L103
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 104-104: src/StringManipulation.php#L104
Operation must be bracketed

212-218: Consistent parameter naming in UTF-8 conversion.

Changing parameter name from $valor to $value improves naming consistency throughout the codebase and aligns with English naming conventions.

Fix spacing between parameter and default value:
-public static function utf8Ansi(?string $value = ''): string
+public static function utf8Ansi(?string $value=''): string
🧰 Tools

🪛 GitHub Check: Codacy Static Code Analysis

[notice] 217-217: src/StringManipulation.php#L217
Incorrect spacing between argument "$value" and equals sign; expected 0 but found 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d24e598 and fe2185d.

📒 Files selected for processing (6)

README.md (6 hunks)
composer.json (1 hunks)
src/AccentNormalization.php (0 hunks)
src/StringManipulation.php (7 hunks)
src/UnicodeMappings.php (1 hunks)
tests/Unit/StrReplaceTest.php (1 hunks)

💤 Files with no reviewable changes (1)

src/AccentNormalization.php

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.php`: Review PHP code for adherence to PER Coding Style 2.0 guidelines. Ensure proper namespace usage, code organisation, and separation of concerns. Verify that SOLID princi...

**/*.php: Review PHP code for adherence to PER Coding Style 2.0 guidelines. Ensure proper namespace usage, code organisation, and separation of concerns. Verify that SOLID principles are followed and encourage FOOP techniques—such as employing immutable data, pure functions, and functional composition—to improve maintainability, testability, and performance.

src/UnicodeMappings.php
tests/Unit/StrReplaceTest.php
src/StringManipulation.php

🪛 GitHub Check: Codacy Static Code Analysis

tests/Unit/StrReplaceTest.php

[notice] 72-72: tests/Unit/StrReplaceTest.php#L72
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 76-76: tests/Unit/StrReplaceTest.php#L76
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 81-81: tests/Unit/StrReplaceTest.php#L81
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 90-90: tests/Unit/StrReplaceTest.php#L90
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 92-92: tests/Unit/StrReplaceTest.php#L92
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 96-96: tests/Unit/StrReplaceTest.php#L96
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 99-99: tests/Unit/StrReplaceTest.php#L99
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 104-104: tests/Unit/StrReplaceTest.php#L104
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 106-106: tests/Unit/StrReplaceTest.php#L106
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 109-109: tests/Unit/StrReplaceTest.php#L109
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 112-112: tests/Unit/StrReplaceTest.php#L112
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 123-123: tests/Unit/StrReplaceTest.php#L123
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 127-127: tests/Unit/StrReplaceTest.php#L127
Inline comments must end in full-stops, exclamation marks, or question marks

src/StringManipulation.php

[notice] 44-44: src/StringManipulation.php#L44
Array key not aligned correctly; expected 49 spaces but found 8

[notice] 45-45: src/StringManipulation.php#L45
Array key not aligned correctly; expected 49 spaces but found 8

[notice] 46-46: src/StringManipulation.php#L46
Closing parenthesis not aligned correctly; expected 48 spaces but found 4

[notice] 84-84: src/StringManipulation.php#L84
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 100-100: src/StringManipulation.php#L100
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 103-103: src/StringManipulation.php#L103
Inline comments must end in full-stops, exclamation marks, or question marks

[notice] 104-104: src/StringManipulation.php#L104
Operation must be bracketed

[notice] 217-217: src/StringManipulation.php#L217
Incorrect spacing between argument "$value" and equals sign; expected 0 but found 1

🪛 GitHub Check: build (8.4)

tests/Unit/StrReplaceTest.php

[failure] 74-74:
Dynamic call to static method PHPUnit\Framework\Assert::assertSame().

[failure] 78-78:
Dynamic call to static method PHPUnit\Framework\Assert::assertSame().

[failure] 100-100:
Dynamic call to static method PHPUnit\Framework\Assert::assertSame().

[failure] 101-101:
Dynamic call to static method PHPUnit\Framework\Assert::assertSame().

[failure] 114-114:
Dynamic call to static method PHPUnit\Framework\Assert::assertSame().

[failure] 115-115:
Dynamic call to static method PHPUnit\Framework\Assert::assertSame().

[failure] 125-125:
Dynamic call to static method PHPUnit\Framework\Assert::assertSame().

[failure] 129-129:
Dynamic call to static method PHPUnit\Framework\Assert::assertSame().

🪛 GitHub Check: build (8.3)