Conversation
bal-e
force-pushed
the
misc-signer-prep
branch
2 times, most recently
from
5f2fc0e to
08538f2
Compare
mozzieongit
reviewed
Mar 3, 2026
ximon18
reviewed
Mar 3, 2026
| /// Given the old and new scheduled times for an item, the scheduler's state | ||
| /// will be updated, so that the item is refreshed at the new scheduled time | ||
| /// (if any) instead of the old. | ||
| pub fn update(&self, item: &T, old: Option<Instant>, new: Option<Instant>) { |
Member
There was a problem hiding this comment.
The fn doc string doesn't explain why the instants are optional or what it means if one or the other is None.
Contributor
Author
There was a problem hiding this comment.
I've extended the documentation to better explain what this function does.
ximon18
reviewed
Mar 3, 2026
ximon18
reviewed
Mar 3, 2026
src/common/scheduler.rs
Outdated
| } | ||
|
|
||
| (None, Some(item)) => { | ||
| // If the item is already present in the schedule, an internal |
Member
There was a problem hiding this comment.
Do you not want to detect and warn about this case?
Contributor
Author
There was a problem hiding this comment.
I've added trace message logging.
mozzieongit
approved these changes
Mar 3, 2026
- Typos. - Move 'force_future()' to a standalone fn.
This factors out basic logic from 'loader/refresh.rs' for use in other places (e.g. re-signing schedules).
Now it will only show the name of the zone.
Contributor
Author
|
Force-pushing to clean up history before I merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are miscellaneous commits I piled up while integrating the zone signer with the new zone storage. An overview:
Debugfor the zone builder types so I can hold them inZoneState.RefreshMonitorinto a genericScheduler, so it can be used for tracking zone re-signing too.Loader::remove_zone(), as it contained makeshift code that accessed the internals of theRefreshMonitor. Once inlined, the problem goes away.force_future()a standalone function inzone/storage.rsso it looks less weird when I use it in multipleimplblocks.