fix: mark all devices unhealthy if NVML health check failed to start#1641
Open
devincd wants to merge 2 commits intoNVIDIA:mainfrom
Open
fix: mark all devices unhealthy if NVML health check failed to start#1641devincd wants to merge 2 commits intoNVIDIA:mainfrom
devincd wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
…eckhealth failure. Update health check error logging to mark devices as unhealthy. Signed-off-by: devincd <505259926@qq.com>
Signed-off-by: devincd <505259926@qq.com>
b0f7c75 to
20df1c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Overview
This PR ensures that if the NVML health check fails to initialize during the plugin startup phase (e.g.,
nvml.Init()returnsERROR_UNKNOWN), all managed devices are immediately marked as Unhealthy.The Problem
Currently, when
CheckHealthfails to start, the plugin logs an error but continues to serve. This creates a "Zombie Node" state where:GetPreferredAllocationcalls fail because NVML is unstable.UnexpectedAdmissionErrorloop, which can lead tokube-apiserverandetcdOOM due to high-frequency object churn.The Fix
By marking all devices as Unhealthy when the health check fails to initialize:
Verification Results
[✓] Verified that if
nvml.Init()fails in the health check goroutine,ListAndWatchsends an unhealthy list to Kubelet.[✓] Verified that the Node's
allocatableGPU count drops to 0 in the Kubernetes API.Fixes #1640