Skip to content

fix: mark all devices unhealthy if NVML health check failed to start #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devincd wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: mark all devices unhealthy if NVML health check failed to start #1641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccc8fc6
Improve health check error handling; Mark all unhealthy when start ch…
devincd Mar 3, 2026
20df1c4
update log
devincd Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion internal/plugin/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,10 @@ func (plugin *nvidiaDevicePlugin) Start(kubeletSocket string) error {
// TODO: add MPS health check
err := plugin.rm.CheckHealth(plugin.stop, plugin.health)
if err != nil {
klog.Errorf("Failed to start health check: %v; continuing with health checks disabled", err)
klog.Errorf("Failed to start health check: %v; marking all devices as unhealthy; continuing with health checks disabled", err)
for _, d := range plugin.Devices() {
plugin.health <- d
}
}
}()

Expand Down