fix: download file will throw error when dir is empty#13
Closed
jiuker wants to merge 1 commit intoNVIDIA:mainfrom
Closed
fix: download file will throw error when dir is empty#13jiuker wants to merge 1 commit intoNVIDIA:mainfrom
jiuker wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Collaborator
|
Need a rebase so the check workflow runs (bug in our GHA definitions). |
fix: download file will throw error when dir is empty
6fb2991 to
aa1420b
Compare
Author
Rebased |
Collaborator
|
Looks like some flakiness with the order |
Collaborator
|
Passed. Mirroring the PR internally (moving development to GitHub is the plan later on). |
Collaborator
|
Internally mirrored PR merged. Merged commit ID is This will be mirrored back to GitHub on the next release. Note the author information will be wrong due to GitLab making the merging user the squashed + merged commit's author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
if we run client like this
client.download_file("dir/to-copy.py", "to-copy.py")will got this
Usage
You can potentially add a usage example below.
# Add a code snippet demonstrating how to use this.Before your PR is "Ready for review"
.release_notes/.unreleased.md?Additional Information