Skip to content

fix: download file will throw error when dir is empty #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jiuker wants to merge 1 commit into from
Closed

fix: download file will throw error when dir is empty #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/multistorageclient/providers/ais.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,8 @@ def _download_file(self, remote_path: str, f: Union[str, IO], metadata: Optional
metadata = self._get_object_metadata(remote_path)

if isinstance(f, str):
os.makedirs(os.path.dirname(f), exist_ok=True)
if os.path.dirname(f):
os.makedirs(os.path.dirname(f), exist_ok=True)
with open(f, "wb") as fp:
fp.write(self._get_object(remote_path))
else:
Expand Down
3 changes: 2 additions & 1 deletion src/multistorageclient/providers/azure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,8 @@ def _download_file(self, remote_path: str, f: Union[str, IO], metadata: Optional
self._refresh_blob_service_client_if_needed()

if isinstance(f, str):
os.makedirs(os.path.dirname(f), exist_ok=True)
if os.path.dirname(f):
os.makedirs(os.path.dirname(f), exist_ok=True)

def _invoke_api() -> int:
blob_client = self._blob_service_client.get_blob_client(container=container_name, blob=blob_name)
Expand Down
3 changes: 2 additions & 1 deletion src/multistorageclient/providers/gcs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,8 @@ def _download_file(self, remote_path: str, f: Union[str, IO], metadata: Optional
bucket, key = split_path(remote_path)

if isinstance(f, str):
os.makedirs(os.path.dirname(f), exist_ok=True)
if os.path.dirname(f):
os.makedirs(os.path.dirname(f), exist_ok=True)
# Download small files
if metadata.content_length <= self._multipart_threshold:
with tempfile.NamedTemporaryFile(mode="wb", delete=False, dir=os.path.dirname(f), prefix=".") as fp:
Expand Down
3 changes: 2 additions & 1 deletion src/multistorageclient/providers/oci.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,8 @@ def _download_file(self, remote_path: str, f: Union[str, IO], metadata: Optional
bucket, key = split_path(remote_path)

if isinstance(f, str):
os.makedirs(os.path.dirname(f), exist_ok=True)
if os.path.dirname(f):
os.makedirs(os.path.dirname(f), exist_ok=True)

def _invoke_api() -> int:
response = self._oci_client.get_object(
Expand Down
3 changes: 2 additions & 1 deletion src/multistorageclient/providers/posix_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,8 @@ def _download_file(self, remote_path: str, f: Union[str, IO], metadata: Optional
if isinstance(f, str):

def _invoke_api() -> int:
os.makedirs(os.path.dirname(f), exist_ok=True)
if os.path.dirname(f):
os.makedirs(os.path.dirname(f), exist_ok=True)
atomic_write(source=remote_path, destination=f)

return filesize
Expand Down
3 changes: 2 additions & 1 deletion src/multistorageclient/providers/s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,8 @@ def _download_file(self, remote_path: str, f: Union[str, IO], metadata: Optional

if isinstance(f, str):
bucket, key = split_path(remote_path)
os.makedirs(os.path.dirname(f), exist_ok=True)
if os.path.dirname(f):
os.makedirs(os.path.dirname(f), exist_ok=True)

# Download small files
if metadata.content_length <= self._transfer_config.multipart_threshold:
Expand Down
Loading