Open
Conversation
This was referenced Jan 29, 2018
This was referenced Jan 29, 2018
wangw90
reviewed
Feb 6, 2018
src/it/resources/local.conf
Outdated
| queue = "dwimyQueue" | ||
| routingKey = "" | ||
| fileName = "~/output1.json" | ||
| queue = "dmTestQueue" |
Collaborator
There was a problem hiding this comment.
better replace "dm" with something else
wangw90
reviewed
Feb 6, 2018
|
|
||
|
|
||
|
|
||
| //trait QueueSubscriber { |
Collaborator
There was a problem hiding this comment.
can we delete these commented code if no longer in use?
wangw90
reviewed
Feb 6, 2018
| import scalaz.stream._ | ||
|
|
||
| case class Cxn(filename: String, nextMessage: () => RabbitResponse, disconnect: () => Try[Unit]) | ||
| case class Sxn(subscription:((Try[RabbitResponse] => Unit) => String), disconnect: () => Try[Unit]) |
Collaborator
There was a problem hiding this comment.
not sure what exactly Cxn and Sxn mean (Connection and Session?)
can we use more explicit names to avoid confusion?
rodoherty1
reviewed
Feb 12, 2018
| import scalaz.stream._ | ||
|
|
||
| case class Cxn(filename: String, nextMessage: () => RabbitResponse, disconnect: () => Try[Unit]) | ||
| case class Sxn(subscription:((Try[RabbitResponse] => Unit) => String), disconnect: () => Try[Unit]) |
Contributor
There was a problem hiding this comment.
Let's have a chat about how we could refactor Sxn. It looks like it's a case class that holds functions that manage a user's attempt to subscribe to a Rabbit queue. Perhaps it doesn't belong in a case class and we could capture some logic in a plain old object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rabbit Consumer code is added for the following