Conversation
Member
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
Before this change: the font-size was set using css, i.e `font-size: 0.65rem`. It led to wrong highlight / selectable text on Chrome as it bypasses internal Monaco properties. The fix: * removes the font-size from scss sources * defines fontSize in Monaco editor property * defines lineHeight to fit with current line height property
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #2414 +/- ##
===========================================
- Coverage 48.33% 46.99% -1.34%
===========================================
Files 955 1223 +268
Lines 19801 22731 +2930
Branches 5922 6748 +826
===========================================
+ Hits 9571 10683 +1112
- Misses 8409 10019 +1610
- Partials 1821 2029 +208
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rmnbrd
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue:
The font-size was set using css, i.e
font-size: 0.65rem.It led to wrong highlight / selectable text on Chrome as it bypasses internal Monaco properties.
The current fix:
Screeshots diff