Skip to content

Comments

fix(qov-1607) Fix monaco editors font-size issue#2414

Merged
rmnbrd merged 1 commit intostagingfrom
qov-1607
Feb 24, 2026
Merged

fix(qov-1607) Fix monaco editors font-size issue#2414
rmnbrd merged 1 commit intostagingfrom
qov-1607

Conversation

@mzottola
Copy link
Contributor

@mzottola mzottola commented Feb 24, 2026

Summary

Issue:
The font-size was set using css, i.e font-size: 0.65rem.
It led to wrong highlight / selectable text on Chrome as it bypasses internal Monaco properties.

The current fix:

  • removes the font-size from scss sources
  • defines fontSize in Monaco editor property
  • defines lineHeight to fit with current line height property

Screeshots diff

  • Before (on chrome)
image
  • After (on chrome)
image

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 939e824e-ace5-46db-852e-4db251209aeb test-prod-clone
/qovery preview 964984c5-fba6-4371-88d3-a5daf99642ab test-prod
/qovery preview e68a6997-01bc-4a01-adcd-e763ade8d2ae test-prod-clone-pipeline-clone-test
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Don’t Sacrifice Readability, you are going to debug it in 6 months

Before this change: the font-size was set using css, i.e `font-size:
0.65rem`. It led to wrong highlight / selectable text on Chrome as it
bypasses internal Monaco properties.

The fix:
* removes the font-size from scss sources
* defines fontSize in Monaco editor property
* defines lineHeight to fit with current line height property
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.99%. Comparing base (af019ef) to head (fb28d0c).
⚠️ Report is 1 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2414      +/-   ##
===========================================
- Coverage    48.33%   46.99%   -1.34%     
===========================================
  Files          955     1223     +268     
  Lines        19801    22731    +2930     
  Branches      5922     6748     +826     
===========================================
+ Hits          9571    10683    +1112     
- Misses        8409    10019    +1610     
- Partials      1821     2029     +208     
Flag Coverage Δ
unittests 46.99% <ø> (-1.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd merged commit c65a102 into staging Feb 24, 2026
9 of 10 checks passed
@rmnbrd rmnbrd deleted the qov-1607 branch February 24, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants