Skip to content

fix(qov-1607) Fix monaco editors font-size issue #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmnbrd merged 1 commit into from
Feb 24, 2026
+10 −7
Merged

fix(qov-1607) Fix monaco editors font-size issue #2414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion libs/shared/ui/src/lib/components/code-diff-editor/code-diff-editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
.view-line,
.line-numbers {
font-family: monospace !important;
font-size: 0.65rem;
}

// JSON values in the diff
Expand Down
2 changes: 2 additions & 0 deletions libs/shared/ui/src/lib/components/code-diff-editor/code-diff-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ export function CodeDiffEditor({
readOnly: true,
originalEditable: false,
minimap: { enabled: false },
fontSize: 10.4,
lineHeight: 19,
lineNumbers: 'on',
scrollBeyondLastLine: false,
automaticLayout: true,
Expand Down
5 changes: 0 additions & 5 deletions libs/shared/ui/src/lib/components/code-editor/code-editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
.view-line,
.line-numbers {
font-family: monospace !important;
font-size: 0.65rem;
}

// JSON Values
Expand Down Expand Up @@ -55,7 +54,6 @@
.view-line {
background-color: #e6f6eb7f;
font-family: monospace !important;
font-size: 0.65rem;
}

.margin-view-overlays {
Expand All @@ -66,7 +64,6 @@
.line-numbers {
color: #218358 !important;
font-family: monospace !important;
font-size: 0.65rem;
}
}

Expand All @@ -75,7 +72,6 @@
.view-line {
background-color: rgba(246, 231, 230, 0.5);
font-family: monospace !important;
font-size: 0.65rem;
}

.margin-view-overlays {
Expand All @@ -86,6 +82,5 @@
.line-numbers {
color: #e89381 !important;
font-family: monospace !important;
font-size: 0.65rem;
}
}
9 changes: 8 additions & 1 deletion libs/shared/ui/src/lib/components/code-editor/code-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
import { Editor as CodeEditorMonaco, type EditorProps as CodeEditorMonacoProps } from '@monaco-editor/react'
import {
Editor as CodeEditorMonaco,
type EditorProps as CodeEditorMonacoProps,
type Monaco,
} from '@monaco-editor/react'
import type { editor } from 'monaco-editor'
import LoaderSpinner from '../loader-spinner/loader-spinner'
import './code-editor.scss'

Expand All @@ -13,6 +18,8 @@ export function CodeEditor({ readOnly, options, ...props }: CodeEditorProps) {
loading={<LoaderSpinner />}
options={{
minimap: { enabled: false },
fontSize: 10.4,
lineHeight: 19,
readOnly,
...options,
}}
Expand Down