Conversation
charleshofer
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The JAX ROCm plugin wheel build fails with the following error:
The XLA build process includes a genrule (
@@xla//xla/backends/gpu/target_config:embed_gpu_specs_gen) that embeds GPU specification files into C++ code using thexxdutility. Thexxdcommand is used to convert binary/text files into C-style hex arrays:The
xxdutility is not installed in the manylinux builder Docker image, causing the build to fail.Solution
Add the
vim-commonpackage to the manylinux Dockerfile. On RHEL/AlmaLinux-based systems (whichmanylinux_2_28is based on),xxdis provided by thevim-commonpackage.Submission Checklist