Skip to content

Fix: Add vim-common package to manylinux Docker image for XLA build #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ruturaj4 merged 1 commit into from
Feb 23, 2026
+3 −7
Merged

Fix: Add vim-common package to manylinux Docker image for XLA build #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/manylinux/Dockerfile.jax-manylinux_2_28-rocm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ENV GPU_DEVICE_TARGETS="gfx906 gfx908 gfx90a gfx942 gfx950 gfx1030 gfx1100 gfx11

# Install patchelf and headers for numactl
RUN --mount=type=cache,target=/var/cache/dnf \
dnf install -y patchelf numactl-devel
dnf install -y patchelf numactl-devel vim-common

# Install ROCm
RUN --mount=type=cache,target=/var/cache/dnf \
Expand Down
2 changes: 1 addition & 1 deletion docker/manylinux/Dockerfile.jax-manylinux_2_28-therock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ENV GPU_DEVICE_TARGETS="gfx906 gfx908 gfx90a gfx942 gfx950 gfx1030 gfx1100 gfx11

# Install patchelf and headers for numactl
RUN --mount=type=cache,target=/var/cache/dnf \
dnf install -y patchelf numactl-devel
dnf install -y patchelf numactl-devel vim-common

# Install ROCm
RUN --mount=type=cache,target=/var/cache/dnf \
Expand Down
6 changes: 1 addition & 5 deletions jax_rocm_plugin/build/rocm/build_wheels/Dockerfile.manylinux_2_28_x86_64.rocm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ ARG ROCM_BUILD_JOB
ARG ROCM_BUILD_NUM
ARG THEROCK_PATH

# Install system GCC and C++ libraries, and build deps
RUN --mount=type=cache,target=/var/cache/dnf \
dnf install -y patchelf numactl-devel

RUN --mount=type=cache,target=/var/cache/dnf \
--mount=type=bind,source=build/rocm/tools/get_rocm.py,target=get_rocm.py \
--mount=type=bind,from=therock,target=/tmp/therock/ \
Expand All @@ -20,7 +16,7 @@ RUN printf '%s\n' > /opt/rocm/bin/target.lst ${GPU_DEVICE_TARGETS}

# Install LLVM 18 and dependencies.
RUN --mount=type=cache,target=/var/cache/dnf \
dnf install -y patchelf numactl-devel python3.11 python3.11-devel python3.11-pip wget && \
dnf install -y patchelf numactl-devel vim-common python3.11 python3.11-devel python3.11-pip wget && \
rm -f /usr/bin/python3 && ln -sf /usr/bin/python3.11 /usr/bin/python3 && \
rm -f /usr/bin/pip3 && ln -sf /usr/bin/pip3.11 /usr/bin/pip3 && \
python3.11 -m pip install --upgrade pip setuptools wheel
Expand Down
Loading