Fix: Can now force character independence regardless of current following status.#54
Open
markscho wants to merge 5 commits intoRanvierMUD:masterfrom
Open
Fix: Can now force character independence regardless of current following status.#54markscho wants to merge 5 commits intoRanvierMUD:masterfrom
markscho wants to merge 5 commits intoRanvierMUD:masterfrom
Conversation
…w properly hydrate.
shawncplus
reviewed
Feb 24, 2019
| */ | ||
| this.emit('unfollowed', this.following); | ||
| this.following = null; | ||
| if (this.following) { |
Member
There was a problem hiding this comment.
I'm a proponent of early return. So instead of wrapping the entire function body in an if, you can instead just do
if (!this.following) {
return
}
azigler
added a commit
to azigler/core
that referenced
this pull request
Jun 6, 2020
azigler
added a commit
to azigler/core
that referenced
this pull request
Jun 6, 2020
azigler
added a commit
to azigler/core
that referenced
this pull request
Jun 6, 2020
This reverts commit bc2bddb.
|
I added the early return in #121. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you want to ensure that character (NPC or Player) is not following anyone, you call the .unfollow() method. But this blows up if the character isn't currently following anyone.
Solution: Check to see if the character is currently following someone before attempting to perform standard unfollow procedures.